-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple docker images #1371
Decouple docker images #1371
Conversation
Added a few comments, nothing super major @iameskild, thanks for sorting this out |
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
…into use-nebari-docker-images
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
@trallard I believe this ready for a final review. Once this PR is merged, all future updates to the images will need to be made in the nebari-docker-images repo 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good solution moving forward for updating the nebari image tags. Happy to see that we are decoupling the docker images from Nebari!
Fixes | Closes | Resolves - related to #1292
Changes introduced in this PR:
kubernetes.yaml
), we will pull the latest image tagged from themain
branch ofnebari-docker-images
to ensure that everything from both repos works together. I believe this preserves the spirit of how the tags were set prior to this change.qhub init
, a small function (set_qhub_image_tag
) will download a list of the GitHub tags for thenebari-docker-images
repo and use the latest (no dev or pre-releases) tag.qhub_dask_version
as well.QHUB_IMAGE_TAG
environment variable.QHUB_DASK_VERSION
) has been introduced to override theqhub_dask_version
.Types of changes
What types of changes does your PR introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Documentation
Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.