-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade kbatch version #1335
Upgrade kbatch version #1335
Conversation
I cut a new release of kbatch over the weekend in preparation for this update. Once upgraded, it will enable kbatch cronjob support. Documentation and tutorials to come this week. |
qhub/template/stages/07-kubernetes-services/modules/kubernetes/services/kbatch/main.tf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I will update this once I get this kbatch fix in and cut a new release: |
@viniciusdc this is ready for a final review as well. I just released 0.4.1 of kbatch which was holding this PR up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after merge please run the integration tests and update beta
to inspect the latest changes 🙂
Fixes | Closes | Resolves #1311
Changes introduced in this PR:
Types of changes
What types of changes does your PR introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Documentation
Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.