Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kbatch version #1335

Merged
merged 7 commits into from
Jul 1, 2022
Merged

Upgrade kbatch version #1335

merged 7 commits into from
Jul 1, 2022

Conversation

iameskild
Copy link
Member

Fixes | Closes | Resolves #1311

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

  • Upgrade kbatch to v0.4.0 which adds cronjob support

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): version upgrade

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@iameskild iameskild changed the title [WIP] Upgrade kbatch version Upgrade kbatch version Jun 20, 2022
@iameskild
Copy link
Member Author

iameskild commented Jun 20, 2022

I cut a new release of kbatch over the weekend in preparation for this update. Once upgraded, it will enable kbatch cronjob support. Documentation and tutorials to come this week.

@trallard trallard added the needs: review 👀 This PR is complete and ready for reviewing label Jun 21, 2022
@iameskild iameskild requested a review from aktech June 21, 2022 22:53
Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@iameskild iameskild added this to the Release v0.4.3 milestone Jun 23, 2022
@iameskild
Copy link
Member Author

iameskild commented Jun 23, 2022

I will update this once I get this kbatch fix in and cut a new release:
kbatch-dev/kbatch#46

@iameskild
Copy link
Member Author

@viniciusdc this is ready for a final review as well. I just released 0.4.1 of kbatch which was holding this PR up.

Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after merge please run the integration tests and update beta to inspect the latest changes 🙂

@viniciusdc viniciusdc merged commit 58870fc into main Jul 1, 2022
@iameskild iameskild deleted the 20220619eae branch August 18, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: user experience 👩🏻‍💻 needs: review 👀 This PR is complete and ready for reviewing status: in progress 🏗 This task is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade kbatch/kbatch-proxy version
4 participants