Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefect token var to CI when needed #1279

Merged
merged 3 commits into from
May 24, 2022
Merged

Add prefect token var to CI when needed #1279

merged 3 commits into from
May 24, 2022

Conversation

viniciusdc
Copy link
Contributor

Fixes | Closes | Resolves #878

Changes introduced in this PR:

  • Add a secret key to CI/CD config on GH, for when Prefect token is required
  • Changed Prefect token env var syntax from TF_VAR_prefect_token to QHUB_SECRET_PREFECT_TOKEN

The reason why I changed the syntax lies in the fact we now support the direct inclusion of variables to terraform which was not feasible by Terraform infrastructure only in 0.3.+. Also, by using the QHUB_SECRET prefix, we are indeed using the omitting sensitive values settings from this type of information.

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

This (Prefect) still needs to be fully tested to validate which configuration might need to be managed since the 0.4.0 changes took place. #1217

@viniciusdc
Copy link
Contributor Author

This basically only updates the CI to catch the prefect token and add to workflow yaml, if prefect is enabled

@viniciusdc viniciusdc merged commit 0b5b098 into main May 24, 2022
@viniciusdc viniciusdc deleted the fix-878-prefect branch August 18, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Prefect environment var missing in git-ops.yaml
1 participant