Add prefect token var to CI when needed #1279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #878
Changes introduced in this PR:
TF_VAR_prefect_token
toQHUB_SECRET_PREFECT_TOKEN
The reason why I changed the syntax lies in the fact we now support the direct inclusion of variables to terraform which was not feasible by Terraform infrastructure only in 0.3.+. Also, by using the
QHUB_SECRET
prefix, we are indeed using the omitting sensitive values settings from this type of information.Types of changes
What types of changes does your PR introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Documentation
Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?
Further comments (optional)
This (Prefect) still needs to be fully tested to validate which configuration might need to be managed since the 0.4.0 changes took place. #1217