Argo Workflows #1252

Adam-D-Lewis · 2022-04-15T15:26:43Z

Fixes | Closes | Resolves #

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds a feature)
Breaking change (fix or feature that would cause existing features to not work as expected)
Documentation Update
Code style update (formatting, renaming)
Refactoring (no functional changes, no API changes)
Build related changes
Other (please describe):

Testing

Requires testing

Yes
No

In case you checked yes, did you write tests?

Yes
No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

Yes, docstrings
Yes, main documentation
Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

…ces, add custom options for argo helm chart

…rbac for individual argo workflows components

* Mdformat tables (#1186) * Add mdformat-tables * Run mdformat on all files * mdformat only docs folder (restore .github md files) * Fix some vale, restore README/RELEASE * [ImgBot] Optimize images (#1187) /docs/source/images/dev_postman_for_keycloak.png -- 298.79kb -> 270.60kb (9.44%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> * Bump conda-store version to 0.3.14 (#1192) * Allow terraform init to upgrade providers within version specification (#1194) * Allow terraform init to upgrade providers within version specification Closes #1193 * Black formatting * Adding missing __init__ files (#1196) * Adding missing __init__ files Closes #1195 * Explicitely using qhub for package * Give hint on what to include * Release 0.3.15 for Conda-Store (#1205) * Profilegroups (#1203) * Fix in case groups is None * access all/keycloak/yaml * jupyterlabproflies mapper * Keycloak profiles working * ignore changes to keycloak group attributes * qhub upgrade for jupyterlab profiles * docs for jupyterlabprofiles * Renamed to jupyterlab_profiles * Render `.gitignore`, black py files (#1206) * Render .gitignore * Render clean .gitignore * Add unit test * Upgrade black * Upgrade black * black format * exclude qhub/_version.py from black * Black what needs blackening * Fix * Fix * Update qhub-dask version (#1224) * Fix env doc links and add corresponding tests (#1216) * Fix env doc links and add corresponding tests * fix broken image link * fix black formatting * map(any) -> any (#1213) * Update release notes - justification for changes in `v0.4.0` (#1178) * Update release notes * Remove ref to cookiecutter * Update link-checker version * Fix * Use lycee link-checker instead * Remove lycee, update md config.json * Revert version * Release notes cleanup * Rewording * Add to vocab * Fix table * Add explicit warning about release * Update README.md Fixed some syntax/grammar issues. * Minor updates Co-authored-by: Christopher Ostrouchov <chris.ostrouchov@gmail.com> Co-authored-by: Shannon <magsol@gmail.com> * Merge spawner and profile env vars * Support for pinning the IP address of the load balancer via terraform overrides (#1235) * Suport adding load balancer annotations and ip via terraform overrides * add documentation for terraform overrides * make terraform overrides being able to override any variable * Bump moment from 2.29.1 to 2.29.2 in /tests_e2e (#1241) Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.29.2. - [Release notes](https://github.com/moment/moment/releases) - [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md) - [Commits](moment/moment@2.29.1...2.29.2) --- updated-dependencies: - dependency-name: moment dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update cdsdashboards to 0.6.1, Voila to 0.3.5 (#1240) * Update cdsdashboards to 0.6.1 * voila v0.3.5 * Bump minimist from 1.2.5 to 1.2.6 in /tests_e2e (#1208) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * output check fix (#1244) Co-authored-by: Adam-D-Lewis <> * Add auth to argo * add argo_workflows value to qhub init command * update black version * update black in setup.cfg Co-authored-by: Dan Lester <dan@ideonate.com> Co-authored-by: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: Christopher Ostrouchov <chris.ostrouchov@gmail.com> Co-authored-by: Amit Kumar <dtu.amit@gmail.com> Co-authored-by: Shannon <magsol@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adam Lewis <23342526+Adam-D-Lewis@users.noreply.github.com> Co-authored-by: Adam-D-Lewis <>

iameskild · 2022-04-15T19:33:53Z

With the latest commit, I was able to deploy (without the need the cert) and login:

The only remaining issue is the health check at the end of the deployment for https://<qhub-domain>/argo/api/v1/info. If I navigate to that URL, I get a valid response: {"managedNamespace":"dev"}

...mplate/stages/07-kubernetes-services/modules/kubernetes/services/argo-workflows/variables.tf

Adam-D-Lewis · 2022-04-19T15:07:47Z

I've noticed that I get a 401 (Unauthorized) status code when visiting https://<qhub-domain>/argo/api/v1/info before logging in via Keycloak. After logging in, https://<qhub-domain>/argo/api/v1/info gives a 200 response. Same with other argo api urls I tried. Perhaps we just use https://<qhub-domain>.qhub.dev/argo as the health url since the other urls appear to be inaccessible before authenticating.

iameskild · 2022-04-19T15:55:05Z

Good catch @Adam-D-Lewis! The kubernetes test is now passing 🙌

@costrouc I think this PR is ready for another review :)

Adam-D-Lewis · 2022-04-19T15:55:14Z

The only remaining failing test appears to be unrelated to this PR, and I've opened an issue tracking it.

qhub/template/stages/07-kubernetes-services/modules/kubernetes/services/argo-workflows/main.tf

qhub/schema.py

Adam-D-Lewis · 2022-04-23T00:13:47Z

I made some more progress on the roles stuff in the latest commit. We may need to delete the insecure-skip-no-verify stuff still. Also, in the Argo UI, we can see all the roles (jupyterhub, dask, others) instead of just argo roles.

Argo maps roles to service accounts via service account annotations. More info at https://argoproj.github.io/argo-workflows/argo-server-sso/#sso-rbac.

costrouc · 2022-04-26T14:41:21Z

we can see all the roles (jupyterhub, dask, others) instead of just argo roles.

This is a bug in how the https://github.com/Quansight/qhub/tree/main/qhub/template/stages/07-kubernetes-services/modules/kubernetes/services/keycloak-client is configured. Not an issue on your end!

Adam-D-Lewis · 2022-04-26T19:06:17Z

Okay, I think this is ready for re-review @costrouc. Only vale CI test is failing, but I don't know how to disable or override them. Do I need to do that before merging?

costrouc · 2022-04-28T03:21:57Z

@Adam-D-Lewis I'd love to test this out. I likely won't have time until next week but I will put it on my todo list. From looking at the code this looks great it is in great shape!

costrouc

Approving. Once merge conflicts are resolved it looks good to me

Adam-D-Lewis and others added 11 commits April 4, 2022 19:09

initial attempt to add argo-workflows

8d1dd76

add enable/disable argo functionality, comment out juptyerflow resour…

c7e5c1e

…ces, add custom options for argo helm chart

add value.yaml, add ingressroute to expose argo dashboard

25681cf

rename helm deployment

d29ea63

add argo check and only check endpoint that are enabled

12462b6

reorder outputs

43eaa93

add lots of comments for automatic pickup by prometheus and toggling …

a45b218

…rbac for individual argo workflows components

cleanup comments, add emissary containerRuntime by default

ed10a38

first pass at docs

f2d698d

remove jupyterflow commented out resources

ab5ce47

Adam-D-Lewis changed the title ~~Argo~~ Argo Workflows [WIP] Apr 15, 2022

Adam-D-Lewis and others added 3 commits April 15, 2022 10:28

Merge branch 'main' into argo

368b50f

remove comments

0343e0a

Clean up argo auth

33a7103

costrouc reviewed Apr 15, 2022

View reviewed changes

...mplate/stages/07-kubernetes-services/modules/kubernetes/services/argo-workflows/variables.tf Outdated Show resolved Hide resolved

iameskild added 2 commits April 15, 2022 14:18

Fix typo, add node-selector

cbfaaed

Fix, add argo to vocab

0527b94

fix bug and change argo health endpoint

fdb38b2

Adam-D-Lewis requested a review from costrouc April 19, 2022 15:55

costrouc reviewed Apr 20, 2022

View reviewed changes

qhub/template/stages/07-kubernetes-services/modules/kubernetes/services/argo-workflows/main.tf Outdated Show resolved Hide resolved

qhub/schema.py Show resolved Hide resolved

iameskild changed the title ~~Argo Workflows [WIP]~~ Argo Workflows Apr 21, 2022

Adam-D-Lewis added 2 commits April 22, 2022 15:04

add overrides to argo workflows

b6de656

add some argo roles stuff

d74e8ef

magsol modified the milestones: Release v0.4.1, Release v0.4.2 Apr 26, 2022

fix cluster role names

63e2264

Adam-D-Lewis requested a review from costrouc April 26, 2022 19:07

add overrides

a58c187

costrouc approved these changes May 26, 2022

View reviewed changes

costrouc and others added 4 commits May 26, 2022 15:17

Merge remote-tracking branch 'origin/main' into argo

0b91979

merge main

a4e7892

clean up

eeef096

Update readme

2da4ebf

iameskild merged commit 2687f13 into main May 26, 2022

iameskild deleted the argo branch May 26, 2022 22:15

rsignell-usgs mentioned this pull request Dec 15, 2022

Run Argo workflows on nextgen-dev cluster asascience-open/nextgen-dmac#30

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Argo Workflows #1252

Argo Workflows #1252

Adam-D-Lewis commented Apr 15, 2022 •

edited

Loading

iameskild commented Apr 15, 2022 •

edited

Loading

Adam-D-Lewis commented Apr 19, 2022 •

edited

Loading

iameskild commented Apr 19, 2022

Adam-D-Lewis commented Apr 19, 2022 •

edited

Loading

Adam-D-Lewis commented Apr 23, 2022 •

edited

Loading

costrouc commented Apr 26, 2022 •

edited

Loading

Adam-D-Lewis commented Apr 26, 2022 •

edited

Loading

costrouc commented Apr 28, 2022

costrouc left a comment

Argo Workflows #1252

Argo Workflows #1252

Conversation

Adam-D-Lewis commented Apr 15, 2022 • edited Loading

Changes introduced in this PR:

Types of changes

Testing

Requires testing

In case you checked yes, did you write tests?

Documentation

Further comments (optional)

iameskild commented Apr 15, 2022 • edited Loading

Adam-D-Lewis commented Apr 19, 2022 • edited Loading

iameskild commented Apr 19, 2022

Adam-D-Lewis commented Apr 19, 2022 • edited Loading

Adam-D-Lewis commented Apr 23, 2022 • edited Loading

costrouc commented Apr 26, 2022 • edited Loading

Adam-D-Lewis commented Apr 26, 2022 • edited Loading

costrouc commented Apr 28, 2022

costrouc left a comment

Choose a reason for hiding this comment

Adam-D-Lewis commented Apr 15, 2022 •

edited

Loading

iameskild commented Apr 15, 2022 •

edited

Loading

Adam-D-Lewis commented Apr 19, 2022 •

edited

Loading

Adam-D-Lewis commented Apr 19, 2022 •

edited

Loading

Adam-D-Lewis commented Apr 23, 2022 •

edited

Loading

costrouc commented Apr 26, 2022 •

edited

Loading

Adam-D-Lewis commented Apr 26, 2022 •

edited

Loading