-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add markdown formatter for doc wrapping #1152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable to me. is 180 a lot of characters?
i wish that mdformat used the pyproject convention for configuration instead of adding another file. :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@viniciusdc this looks good to me. Following this PR could you make a giant PR commit of strictly only the formatting changes?
Hi @tonyfast, indeed that would be great, they have an open PR to read from I would prefer 88 as the limit to wrap, but I don't want this to be a restriction imposed further in the docs. So my way of thinking about this 180, is that it is "the max" length that needs to be respected. |
Sure, I think it would be best to add those changes within this PR as its the source of the changes... |
1b966fe
to
b07e640
Compare
891bac8
to
1e8f847
Compare
Sorry for the force-pushing, I tried to include the formatted docs, but creating a different PR for that definitely is the best path to go. |
Closes #1113
Changes introduced in this PR:
mdformat
to wrap doc lines, explicitly added the configuration toml to further change in the default settings.Types of changes
What types of changes does your PR introduce?
Put an
x
in the boxes that applyTesting
Requires testing
Further comments (optional)
Any wrapping will automatically happen when a
.md
file is committed.