Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More finely scoped github actions and kubernetes_test build docker images #1088

Merged
merged 14 commits into from
Feb 22, 2022

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Feb 21, 2022

Closes #1084

This PR has a few goals:

  • Make it so that only the tests that need to run actually run for CI given commits
  • build the docker images for each kubernetes test

@costrouc costrouc force-pushed the fix-1084 branch 2 times, most recently from a56d884 to 2abaae6 Compare February 21, 2022 20:10
@costrouc costrouc changed the title More finely scoping tests to run More finely scoped github actions and kubernetes_test build docker images Feb 22, 2022
@costrouc costrouc merged commit 5ce22b1 into main Feb 22, 2022
@costrouc
Copy link
Member Author

Going to merge since this only affects the CI and makes all our other tests more reliable.

@costrouc costrouc deleted the fix-1084 branch February 22, 2022 05:13
@costrouc
Copy link
Member Author

costrouc commented Feb 22, 2022

This also allows for easier local testing. Here is how you can run local tests

export QHUB_GH_BRANCH=qhub-test

mkdir mydeployment
pushd mydeployment

minikube start --driver=docker
eval $(minikube docker-env)

python ../tests/scripts/minikube-loadbalancer-ip.py
minikube addons enable metallb

qhub render --config qhub-config.yaml

pushd image
TAG=qhub-test docker buildx bake
popd

qhub deploy --config qhub-config.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Infra related tests are running on non-code related PRs
1 participant