Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depricating terraform_modules option since no longer used #1057

Merged
merged 2 commits into from
Feb 12, 2022

Conversation

costrouc
Copy link
Member

Depricating terraform_modules option since no longer used. This was part of the original PR in #957 .

@costrouc costrouc requested a review from danlester February 11, 2022 22:28
@costrouc costrouc added this to the Release v0.4.0 milestone Feb 11, 2022
Copy link
Contributor

@danlester danlester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to add this to 0.4.0-specific upgrade step in qhub/upgrade.py:

        if "terraform_modules" in config:
            del config["terraform_modules"]
            print(
                "Removing terraform_modules field from config as it is no longer used.\n"
            )

@danlester
Copy link
Contributor

I've added this now.

@danlester danlester merged commit 2be3bce into main Feb 12, 2022
@costrouc costrouc deleted the fix-depreciate-terraform-modules-option branch August 23, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants