Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup adding support for security.keycloak.realm_display_name key #1054

Merged
merged 1 commit into from
Feb 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion qhub/deploy.py
Original file line number Diff line number Diff line change
Expand Up @@ -603,11 +603,13 @@ def _attempt_keycloak_connection(

def provision_06_kubernetes_keycloak_configuration(stage_outputs, config, check=True):
directory = "stages/06-kubernetes-keycloak-configuration"
realm_id = f"qhub-{config['project_name']}"

stage_outputs[directory] = terraform.deploy(
directory=directory,
input_vars={
"realm": f"qhub-{config['project_name']}",
"realm": realm_id,
"realm_display_name": config['security']['keycloak'].get('realm_display_name', realm_id),
"authentication": config["security"]["authentication"],
},
)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
resource "keycloak_realm" "main" {
provider = keycloak

realm = var.realm
realm = var.realm
display_name = var.realm_display_name
}


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ variable "realm" {
type = string
}

variable "realm_display_name" {
description = "Keycloak realm display name for QHub"
type = string
}

variable "keycloak_groups" {
description = "Permission groups in keycloak used for granting access to services"
type = set(string)
Expand Down