Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - guided-init fails #2024

Closed
nkaretnikov opened this issue Sep 22, 2023 · 2 comments · Fixed by #2025
Closed

[BUG] - guided-init fails #2024

nkaretnikov opened this issue Sep 22, 2023 · 2 comments · Fixed by #2025
Labels
type: bug 🐛 Something isn't working

Comments

@nkaretnikov
Copy link

Describe the bug

Attempted a local guided deploy, got a traceback.

% nebari init --guided-init

        Welcome to the Guided Init wizard!

You will be asked a few questions to generate your nebari-config.yaml. For more details, refer to the Nebari docs:

        https://nebari.dev/docs/



 🪴  Nebari runs on a Kubernetes cluster: Where do you want this Kubernetes cluster deployed? is where you want this Kubernetes cluster deployed. For more details, refer to the Nebari docs:

        https://nebari.dev/docs/get-started/deploy


        ❗️ local requires Docker and Kubernetes running on your local machine. Currently only available on Linux OS.
        ❗️ existing refers to an existing Kubernetes cluster that Nebari can be deployed on.

   Where would you like to deploy your Nebari cluster? local
╭─────────────────────────────── Traceback (most recent call last) ────────────────────────────────╮
│ /home/nkaretnikov/nebari/nebari-dev/bin/nebari:8 in <module>                                     │
│                                                                                                  │
│   5 from nebari.__main__ import main                                                             │
│   6 if __name__ == '__main__':                                                                   │
│   7 │   sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0])                         │
│ ❱ 8 │   sys.exit(main())                                                                         │
│   9                                                                                              │
│                                                                                                  │
│ /home/nkaretnikov/nebari/src/nebari/__main__.py:8 in main                                        │
│                                                                                                  │
│    5                                                                                             │
│    6 def main():                                                                                 │
│    7 │   cli = create_cli()                                                                      │
│ ❱  8 │   cli()                                                                                   │
│    9                                                                                             │
│   10                                                                                             │
│   11 # get the click object from the typer app so that we can autodoc the cli                    │
│                                                                                                  │
│ /home/nkaretnikov/nebari/nebari-dev/lib/python3.8/site-packages/typer/main.py:328 in __call__    │
│                                                                                                  │
│ /home/nkaretnikov/nebari/nebari-dev/lib/python3.8/site-packages/typer/main.py:311 in __call__    │
│                                                                                                  │
│ /home/nkaretnikov/nebari/nebari-dev/lib/python3.8/site-packages/click/core.py:1157 in __call__   │
│                                                                                                  │
│ /home/nkaretnikov/nebari/nebari-dev/lib/python3.8/site-packages/typer/core.py:778 in main        │
│                                                                                                  │
│ /home/nkaretnikov/nebari/nebari-dev/lib/python3.8/site-packages/typer/core.py:216 in _main       │
│                                                                                                  │
│ /home/nkaretnikov/nebari/nebari-dev/lib/python3.8/site-packages/click/core.py:1686 in invoke     │
│                                                                                                  │
│ /home/nkaretnikov/nebari/nebari-dev/lib/python3.8/site-packages/click/core.py:943 in             │
│ make_context                                                                                     │
│                                                                                                  │
│ /home/nkaretnikov/nebari/nebari-dev/lib/python3.8/site-packages/click/core.py:1408 in parse_args │
│                                                                                                  │
│ /home/nkaretnikov/nebari/nebari-dev/lib/python3.8/site-packages/click/core.py:2400 in            │
│ handle_parse_result                                                                              │
│                                                                                                  │
│ /home/nkaretnikov/nebari/nebari-dev/lib/python3.8/site-packages/click/core.py:2362 in            │
│ process_value                                                                                    │
│                                                                                                  │
│ /home/nkaretnikov/nebari/nebari-dev/lib/python3.8/site-packages/typer/main.py:994 in wrapper     │
│                                                                                                  │
│ /home/nkaretnikov/nebari/src/_nebari/subcommands/init.py:656 in guided_init_wizard               │
│                                                                                                  │
│   653 │   │   if not disable_checks:                                                             │
│   654 │   │   │   check_cloud_provider_creds(                                                    │
│   655 │   │   │   │   cloud_provider=inputs.cloud_provider,                                      │
│ ❱ 656 │   │   │   │   disable_prompt=ctx.params["disable_prompt"],                               │
│   657 │   │   │   )                                                                              │
│   658 │   │                                                                                      │
│   659 │   │   # specific context needed when `check_project_name` is called                      │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
KeyError: 'disable_prompt'

Expected behavior

Local deploy works or a user-friendly error is thrown.

OS and architecture in which you are running Nebari

Linux

How to Reproduce the problem?

6d01b04
Installed via pip install -e ..

Command output

No response

Versions and dependencies used.

No response

Compute environment

None

Integrations

No response

Anything else?

No response

@nkaretnikov nkaretnikov added needs: triage 🚦 Someone needs to have a look at this issue and triage type: bug 🐛 Something isn't working labels Sep 22, 2023
@nkaretnikov
Copy link
Author

nkaretnikov commented Sep 22, 2023

Also note that some information is missing before "is where you want this Kubernetes cluster deployed." Or maybe the sentence just needs to be rewritten, not sure.

@nkaretnikov
Copy link
Author

nkaretnikov commented Sep 22, 2023

Also tried nebari init -p test, expecting it to ask me to populate some config or something. It just exited silently despite me having nothing deployed.

UPD: looks like this init command succeeded. It would be nice to print a message. Guided init is broken, though.

@dcmcand dcmcand mentioned this issue Sep 22, 2023
10 tasks
iameskild pushed a commit that referenced this issue Sep 22, 2023
@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in 🪴 Nebari Project Management Sep 22, 2023
@Adam-D-Lewis Adam-D-Lewis removed the needs: triage 🚦 Someone needs to have a look at this issue and triage label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants