-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Add doc string to upgrade.py #1792
Comments
Hi there, I can try working on this one upon confirmation. def do_upgrade(config_filename, attempt_fixes=False):
"""
Perform an upgrade of the Nebari configuration file.
This function loads the YAML configuration file, checks for deprecated keys,
validates the current version, and if necessary, upgrades the configuration
to the latest version of Nebari.
Parameters:
config_filename (str): The path to the configuration file.
attempt_fixes (bool): Whether to attempt automatic fixes for validation errors.
Returns:
None
""" Happy to have feedback on it. Thanks 💐 |
Hi @arjxn-py, thanks for contributing! That doc string looks good and I'd be happy to merge a PR with that. Maybe also add something like the following at the top of the file.
|
Pinging @viniciusdc in case he has any thoughts here. |
Thanks so much for the input @Adam-D-Lewis 💐 , I'd be happy to open a PR soon with the docstrings along with the suggested one too. |
I just saw your PR @arjxn-py, fantastic work! thanks for the contribution. |
Thanks for the kind words @viniciusdc, will look forward to contribute more & add value :) 🚀 |
Context
A file level documentation string summarizing how the upgrade sequence works would be highly beneficial.
Value and/or benefit
There are some doc strings on individual methods, but devs have to do quite a bit of reading and digging around the different methods included before they can understand how it all works. A high level doc string would go a long way in helping out.
Anything else?
No response
The text was updated successfully, but these errors were encountered: