Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo jupyter scheduler #465

Merged
merged 9 commits into from
Jun 5, 2024

Conversation

ericdatakelly
Copy link
Contributor

Reference Issues or PRs

Fixes #436

What does this implement/fix?

Updates the tutorial for jupyter-scheduler.

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link

netlify bot commented May 23, 2024

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit e214791
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/6660669ee0c6340008c7da7f
😎 Deploy Preview https://deploy-preview-465--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kcpevey kcpevey requested a review from pt247 June 4, 2024 18:18
@pt247
Copy link
Contributor

pt247 commented Jun 4, 2024

I have suggested minor changes. Looks good otherwise.

Copy link
Contributor

@pt247 pt247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions. Looks good otherwise.

docs/docs/tutorials/run-notebook-as-a-job.md Outdated Show resolved Hide resolved
docs/docs/tutorials/run-notebook-as-a-job.md Outdated Show resolved Hide resolved
docs/docs/tutorials/run-notebook-as-a-job.md Outdated Show resolved Hide resolved
docs/docs/tutorials/run-notebook-as-a-job.md Outdated Show resolved Hide resolved
ericdatakelly and others added 3 commits June 4, 2024 15:52
Co-authored-by: Prashant Tiwari  <pt247@users.noreply.github.com>
Co-authored-by: Prashant Tiwari  <pt247@users.noreply.github.com>
@ericdatakelly
Copy link
Contributor Author

Thanks @pt247 . I accepted your suggestions and made only minor edits on top of them. If you like them, it's ready to merge.

Copy link
Contributor

@kcpevey kcpevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion, otherwise LGTM

docs/docs/tutorials/run-notebook-as-a-job.md Outdated Show resolved Hide resolved
@pt247 pt247 self-requested a review June 5, 2024 13:28
@kcpevey kcpevey merged commit 11ee316 into nebari-dev:main Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[DOC] - Improve documentation for Argo Jupyter Scheduler
3 participants