-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argo jupyter scheduler #465
Conversation
✅ Deploy Preview for nebari-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I have suggested minor changes. Looks good otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions. Looks good otherwise.
Co-authored-by: Prashant Tiwari <pt247@users.noreply.github.com>
Co-authored-by: Prashant Tiwari <pt247@users.noreply.github.com>
Thanks @pt247 . I accepted your suggestions and made only minor edits on top of them. If you like them, it's ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion, otherwise LGTM
Reference Issues or PRs
Fixes #436
What does this implement/fix?
Updates the tutorial for jupyter-scheduler.
Put a
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?