Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kbatch docs #260

Merged
merged 7 commits into from
Jan 26, 2023
Merged

Update kbatch docs #260

merged 7 commits into from
Jan 26, 2023

Conversation

kcpevey
Copy link
Contributor

@kcpevey kcpevey commented Jan 24, 2023

Reference Issues or PRs

#253 - the kbatch docs don't current run

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@kcpevey kcpevey added area: documentation 📖 status: in progress 🏗 This task is currently being worked on labels Jan 24, 2023
@netlify
Copy link

netlify bot commented Jan 24, 2023

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit c0cc7e4
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/63d2cd7ce025bd0009acd75f
😎 Deploy Preview https://deploy-preview-260--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kcpevey kcpevey marked this pull request as ready for review January 24, 2023 19:20
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I made one minor edit but otherwise this is good to merge :)

docs/docs/tutorials/kbatch.md Outdated Show resolved Hide resolved
It's important to remember that you are responsible for deleting cronjobs. If left unchecked, they will continue to run indefinitely.
:::

## **Command Cheat Sheet**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😎

Co-authored-by: eskild <42120229+iameskild@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation 📖 status: in progress 🏗 This task is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants