-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nebari landing page #184
Conversation
…lard/website-copy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some review remarks, but I'm not familiar enough yet with this repo to really review this PR.
I checked the preview deploy URL. I didn't spot any broken links, but I didn't check thoroughly.
All in all, these changes make sense to me.
To clarify - this PR is for you @gabalafou to work off or the landing page (rather than reviewing the PR thoroughly). No need to check for broken links manually as our build setup will throw any broken links automatically. |
Notes from our discussion from Friday. It'll be good to merge this PR soon because we introduce the Adding it to the milestone! |
Okay, so I'm taking over this PR. I'm going to fix the merge conflicts now. Then shall we merge it in? |
It's not ready for merge as is - would need to add an interim landing page. Or the final landing page. I can deal with conflicts. |
@trallard I already fixed the conflicts. 🪄😃 Is there a way we can change this PR so that it both creates a space for me to work in while I build the landing page but without replacing the existing landing page? That way we can merge this PR in sooner rather than later? |
✅ Deploy Preview for nebari-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Ok I had to do some work on the configuration + add redirects to have a "hidden" landing page. @kcpevey and/or @pavithraes - this allows us to merge right now and have the foundation for Gabriel to work on the landing page. Also this Closes #199 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just had a few comments/suggestions
🎉 |
Reference Issues or PRs
#182
What does this implement/fix?
Put an
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?