Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nebari landing page #184

Merged
merged 31 commits into from
Oct 28, 2022
Merged

Add Nebari landing page #184

merged 31 commits into from
Oct 28, 2022

Conversation

trallard
Copy link
Member

@trallard trallard commented Oct 17, 2022

Reference Issues or PRs

#182

What does this implement/fix?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@trallard trallard added type: enhancement 💅🏼 New feature or request status: in progress 🏗 This task is currently being worked on area: community 🪴 Nebari community matters labels Oct 17, 2022
@trallard trallard marked this pull request as draft October 17, 2022 19:04
Copy link
Contributor

@gabalafou gabalafou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some review remarks, but I'm not familiar enough yet with this repo to really review this PR.

I checked the preview deploy URL. I didn't spot any broken links, but I didn't check thoroughly.

All in all, these changes make sense to me.

docs/sidebars.js Show resolved Hide resolved
docs/docs/welcome.mdx Show resolved Hide resolved
.gitpod.yml Show resolved Hide resolved
@trallard
Copy link
Member Author

To clarify - this PR is for you @gabalafou to work off or the landing page (rather than reviewing the PR thoroughly).
Mostly since adding the landing page requires changes to how we handle other routes on the site (and cannot be done directly in main as we have no landing page right now).

No need to check for broken links manually as our build setup will throw any broken links automatically.

@pavithraes pavithraes added this to the 🪴 Nebari rename milestone Oct 23, 2022
@pavithraes
Copy link
Member

Notes from our discussion from Friday.

It'll be good to merge this PR soon because we introduce the /doc subdirectory here that impacts all of our cross-links. :)

Adding it to the milestone!

@gabalafou
Copy link
Contributor

gabalafou commented Oct 24, 2022

Okay, so I'm taking over this PR. I'm going to fix the merge conflicts now. Then shall we merge it in?

@trallard
Copy link
Member Author

It's not ready for merge as is - would need to add an interim landing page. Or the final landing page.

I can deal with conflicts.

@gabalafou
Copy link
Contributor

@trallard I already fixed the conflicts. 🪄😃 Is there a way we can change this PR so that it both creates a space for me to work in while I build the landing page but without replacing the existing landing page? That way we can merge this PR in sooner rather than later?

@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit 418c140
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/635bf19746f588000b317610
😎 Deploy Preview https://deploy-preview-184--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@trallard trallard marked this pull request as ready for review October 26, 2022 17:43
@trallard
Copy link
Member Author

trallard commented Oct 26, 2022

@trallard I already fixed the conflicts. 🪄😃 Is there a way we can change this PR so that it both creates a space for me to work in while I build the landing page but without replacing the existing landing page? That way we can merge this PR in sooner rather than later?

Ok I had to do some work on the configuration + add redirects to have a "hidden" landing page.
But that means we can merge and you can start working off main 🥇

@kcpevey and/or @pavithraes - this allows us to merge right now and have the foundation for Gabriel to work on the landing page.

Also this Closes #199

@trallard trallard added area: documentation 📖 needs: review 👀 and removed status: in progress 🏗 This task is currently being worked on labels Oct 26, 2022
@nebari-dev nebari-dev deleted a comment from netlify bot Oct 26, 2022
Copy link
Contributor

@kcpevey kcpevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just had a few comments/suggestions

docs/docs/how-tos/nebari-aws.md Outdated Show resolved Hide resolved
docs/docs/how-tos/nebari-aws.md Outdated Show resolved Hide resolved
docs/docs/how-tos/using-vscode.md Outdated Show resolved Hide resolved
docs/docusaurus.config.js Show resolved Hide resolved
@trallard trallard merged commit 0a7cb7c into main Oct 28, 2022
@trallard trallard deleted the 182-nebari-website branch October 28, 2022 15:16
@pavithraes
Copy link
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

4 participants