Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set min-width on placeholder #32

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Set min-width on placeholder #32

merged 1 commit into from
Jul 1, 2024

Conversation

krassowski
Copy link
Member

Reference Issues or PRs

Follow-up to #31 based on feedback that the placeholder icon is too small when only one exhibit is present

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

And remove duplicate max-width (also defined in the shard rule above)
@krassowski krassowski added the bug label Jul 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

Binder 👈 Launch a Binder on branch nebari-dev/jupyterlab-gallery/min-width

@krassowski krassowski merged commit 1cfcd92 into main Jul 1, 2024
8 checks passed
@krassowski krassowski deleted the min-width branch July 9, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant