Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance UI Feedback during API calls #85

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Enhance UI Feedback during API calls #85

merged 4 commits into from
Jan 22, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Jan 22, 2024

Reference Issues or PRs

#51 (in reference to 404 errors)

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

N/A

Any other comments?

  • Added Loading indicator to home page Apps and Services grids
  • Updated Create App form to disable Submit until all API dependent fields have loaded
  • Updated to redirect to spawn pending page upon app creation

Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@aktech aktech merged commit cca9c32 into nebari-dev:main Jan 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants