Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable the oauth confirmation screen #458

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

krassowski
Copy link
Member

Reference Issues or PRs

Enables nebari-dev/nebari#2570

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Adds docstring to install_jhub_apps function

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 3:40pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 3:40pm

@aktech
Copy link
Member

aktech commented Aug 15, 2024

This looks good to me, thanks @krassowski

@aktech aktech merged commit 2053970 into nebari-dev:main Aug 15, 2024
25 checks passed
@krassowski krassowski deleted the oauth_no_confirm branch August 16, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants