refactor: remove redundant flat storage methods from RuntimeAdapter #9117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7fb80a9 to
d6d350d
Compare
jbajic
approved these changes
May 29, 2023
Longarithm
approved these changes
May 29, 2023
core/store/src/flat/manager.rs
Outdated
| @@ -82,15 +82,20 @@ impl FlatStorageManager { | |||
| /// the shard's flat storage state hasn't been set before, otherwise it panics. | |||
| /// TODO (#7327): this behavior may change when we implement support for state sync | |||
| /// and resharding. | |||
| pub fn add_flat_storage_for_shard(&self, shard_uid: ShardUId, flat_storage: FlatStorage) { | |||
| pub fn add_flat_storage_for_shard(&self, shard_uid: ShardUId) { | |||
There was a problem hiding this comment.
As we are here - can we fix the comment from like "Add a flat storage state for shard shard_id..." to "Creates FlatStorage for shard shard_uid..."?
d6d350d to
fe14e35
Compare
fe14e35 to
52a00e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #9093
RuntimeAdapterhas access toFlatStorageManagerwhich makes all other flat storage related methods redundant. This PR removes those methods to keepRuntimeAdaptertrait leaner.