Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the secondary stack limit for fuzzing #7195

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

Ekleog
Copy link
Contributor

@Ekleog Ekleog commented Jul 15, 2022

No description provided.

@Ekleog Ekleog requested a review from a team as a code owner July 15, 2022 15:46
@Ekleog Ekleog requested a review from mm-near July 15, 2022 15:46
@matklad
Copy link
Contributor

matklad commented Jul 15, 2022

Does it work? I remeber the stack size being i32 somewhere, so a smoke test would help here. Other than that, sgtm!

@Ekleog
Copy link
Contributor Author

Ekleog commented Jul 15, 2022

I see pub max_stack_height: u32 , and running the cargo-bolero tests does work properly as they're tested by cargo test, so it's probably alright :)

@Ekleog
Copy link
Contributor Author

Ekleog commented Jul 15, 2022

Huuuuh wait it's supposed to be wasmer2_stack_limit not max_stack_height! And this one is actually i32. Pushing a fix :)

@Ekleog Ekleog force-pushed the no-fuzz-secondary-stack-limit branch from c75b3fe to fd5eb20 Compare July 15, 2022 15:53
@Ekleog Ekleog requested a review from matklad July 15, 2022 15:55
@near-bulldozer near-bulldozer bot merged commit 96f13d2 into near:master Jul 15, 2022
@Ekleog
Copy link
Contributor Author

Ekleog commented Jul 19, 2022

@mina86 IIUC https://docs.google.com/spreadsheets/d/1mLljzgL8mfFZjDvIacnzAJRu_lhRjgE4Wjze5SMq6mQ/edit#gid=0 , you're the release owner for 1.28. Do we have a greenlight on backporting this PR to 1.28? This way the fuzzer will be able to look for meaningful things there too, as right now it's finding spurious issues :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants