Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tracing logs in estimator #6956

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

jakmeier
Copy link
Contributor

@jakmeier jakmeier commented Jun 3, 2022

Allow to select tracing levels and targets with the RUST_LOG environment variable when the estimator is running without the --tracing-span-tree flag.

@jakmeier jakmeier requested a review from matklad June 3, 2022 10:36
@jakmeier jakmeier requested a review from a team as a code owner June 3, 2022 10:36
@matklad
Copy link
Contributor

matklad commented Jun 3, 2022

Why do we need to check for --debug flag though? Seems fine to just do this unconditionally?

@jakmeier
Copy link
Contributor Author

jakmeier commented Jun 3, 2022

Why do we need to check for --debug flag though? Seems fine to just do this unconditionally?

I was thinking about interactions with tracing_span_tree, so we can enable them individually or combined. But no strong opinion, if you think it is fine, I can also enable this unconditionally.

@matklad
Copy link
Contributor

matklad commented Jun 3, 2022

Hm, would it work to enable them combined? I think the two would conflict. In this sense, I'd probably expcet

if span_tree {
  enable-span-tree
} else {
  enable-normal-logs
}

@jakmeier
Copy link
Contributor Author

jakmeier commented Jun 3, 2022

Yeah that makes sense!

@jakmeier jakmeier changed the title feat: tracing logs in estimator when using --debug feat: tracing logs in estimator Jun 3, 2022
@near-bulldozer near-bulldozer bot merged commit 70f13ca into near:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants