-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime fuzz: fuzz epoch_length and gas_limit #5132
Conversation
gas_limit: (GAS_1 as f64 * *u.choose(&[0.01, 0.1, 1., 10., 100.])?) as u64, | ||
epoch_length: *u.choose(&[5, 10, 100, 500])? as u64, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are these numbers chosen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intuitively, because I didn't have any ideas on how to do it properly. Open to any suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me!
But I don't know how to verify that the changes here actually improve our fuzzing coverage. Do we have some results here like "it now takes 2x less time to find this injected bug"?
With gas_limit changes I want to emulate congestion and with epoch_length I want to gas price to change. I've tested that both these scenarios now do occur during fuzzing. |
No description provided.