Adding ScenarioBuilder #4812
Merged
Adding ScenarioBuilder #4812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
approved these changes
Sep 9, 2021
Comment on lines
+22
to
+23
| height: 1, | ||
| nonce: 1, |
There was a problem hiding this comment.
Should we start from 0 instead?
There was a problem hiding this comment.
No, I forgot why, but block at height 0 could not be produced
matklad
reviewed
Sep 10, 2021
Comment on lines
+8
to
+11
| pub mod scenario_builder; | ||
|
|
||
| pub use crate::run_test::{BlockConfig, NetworkConfig, Scenario, TransactionConfig}; | ||
| pub use crate::scenario_builder::ScenarioBuilder; |
There was a problem hiding this comment.
This is a minor code smell -- now the caller can use ScenarioBuilder as either runtime_tested::ScenarioBuilder or runtime_tester::scenario_builer::ScenarioBuilder, and it's not immediately clear from the code which variant is preferred.
I usually prefer to make API with only one possilbe import path. For smaller crates, it's usually best for the caller if all the API is available at root, and all the internals are private.
But that's a minor point, the code looks ok as is!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an easier way to create basic scenarios.