Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable in-memory cache for wasmer1 #4301

Merged
merged 2 commits into from
May 17, 2021

Conversation

matklad
Copy link
Contributor

@matklad matklad commented May 13, 2021

This PR ports wasmer0 implementation of in-memory cache to wasme1 as
well.

The goal here is to keep the behavior between two wasmers as close as
possible. We absolutely do want to get rid of the in-memory cache, but
it's safer not to do that while also doing a major wasmer upgrade!

See #4076 (comment)
for context

Test Plan

$ cargo test -p near-vm-runner --features wasmer0_vm,wasmer1_vm,no_cache
$ $ cargo test -p near-vm-runner --features wasmer0_vm,wasmer1_vm

This PR ports wasmer0 implementation of in-memory cache to wasme1 as
well.

The goal here is to keep the behavior between two wasmers as close as
possible. We absolutely do want to get rid of the in-memory cache, but
it's safer not to do that while also doing a major wasmer upgrade!

See near#4076 (comment)
for context
@matklad matklad requested review from ailisp and olonho as code owners May 13, 2021 18:31
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@near-bulldozer near-bulldozer bot merged commit 0f9fe08 into near:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants