Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport wasmer 0.17 FailWithNoError fix to master #4298

Merged
merged 2 commits into from
May 13, 2021
Merged

fix: backport wasmer 0.17 FailWithNoError fix to master #4298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f577c4
fix: backport wasmer 0.17 FailWithNoError fix to master
matklad May 13, 2021
a97bece
Merge branch 'master' into backport
matklad May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion runtime/near-vm-runner/src/wasmer_runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,28 @@ impl IntoVMError for wasmer_runtime::error::RuntimeError {
// invoke returns false and doesn't fill error info what Singlepass BE doesn't.
// Failed unwinder may happen in the case of deep recursion/stack overflow.
// Also can be thrown on unreachable instruction, which is quite unfortunate.
//
// See https://github.com/near/wasmer/blob/0.17.2/lib/runtime-core/src/fault.rs#L285
InvokeError::FailedWithNoError => VMError::FunctionCallError(
FunctionCallError::Nondeterministic("FailedWithNoError".to_string()),
// XXX: Initially, we treated this error case as
// deterministic (so, we stored this error in our state,
// etc.)
//
// Then, in
// https://github.com/near/nearcore/pull/4181#discussion_r606267838
// we reasoned that this error actually happens
// non-deterministically, so it's better to panic in this
// case.
//
// However, when rolling this out, we noticed that this
// error happens deterministically for at least one
// contract. So here we roll this back to a previous
// behavior and emit some deterministic error, which won't
// cause the node to panic.
//
// So far, we are unable to reproduce this deterministic
// failure though.
FunctionCallError::WasmTrap(WasmTrap::Unreachable),
),
// Indicates that a trap occurred that is not known to Wasmer.
// As of 0.17.0, thrown only from Cranelift BE.
Expand Down