Validate each edge only once #4098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmnoxx
commented
Mar 14, 2021
2 tasks
I noticed that on my machine we would spend 20s in Therefore I decided to add MPSC lock-free unbounded queue for sending edges from I'll change it so we spend at most 50ms at a time processing verified edges in |
near-bulldozer bot
pushed a commit
that referenced
this pull request
Mar 17, 2021
Currently we may validate each edge a few times after a node connects to a network. This PR will guarantee that each node edge will be only verified once on node joining the network. Reposting #4098 to fir CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we may validate each edge a few times after a node connects to a network. This PR will guarantee that each node edge will be only verified once on node joining the network.