Fix stake return for double sign slashing #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## staging #1877 +/- ##
===========================================
- Coverage 86.94% 86.83% -0.12%
===========================================
Files 166 166
Lines 31511 31492 -19
===========================================
- Hits 27397 27345 -52
- Misses 4114 4147 +33
Continue to review full report at Codecov.
|
SkidanovAlex
approved these changes
Dec 21, 2019
ilblackdragon
added a commit
that referenced
this pull request
Jan 15, 2020
…ected. Added author to Chunk and Block Validators RPC shows shards/pk, network info RPC shows peer ids for known validators. Make stake naming consistent Print which test is runned before run it (#1889) * Print which test is runned before run it * adding a timeout Add transaction to tx rpc (#1865) * Add transaction to tx rpc * address comments * fix Run test as non root in docker and check binary exist before mount to docker (#1891) * Run test as non root in docker, check is file before mount to docker Fix stake return for double sign slashing (#1877) Addressing comments & fixing fmt Improve naming for stats in the epoch manager. Fix some comments in restaking service Add test for restaked
ilblackdragon
added a commit
that referenced
this pull request
Jan 15, 2020
…ected. Added author to Chunk and Block Validators RPC shows shards/pk, network info RPC shows peer ids for known validators. Make stake naming consistent Print which test is runned before run it (#1889) * Print which test is runned before run it * adding a timeout Add transaction to tx rpc (#1865) * Add transaction to tx rpc * address comments * fix Run test as non root in docker and check binary exist before mount to docker (#1891) * Run test as non root in docker, check is file before mount to docker Fix stake return for double sign slashing (#1877) Addressing comments & fixing fmt Improve naming for stats in the epoch manager. Fix some comments in restaking service Add test for restaked
ilblackdragon
added a commit
that referenced
this pull request
Jan 18, 2020
* Adding restaking tool. Modify RPC for validators to show produced/expected. Added author to Chunk and Block Validators RPC shows shards/pk, network info RPC shows peer ids for known validators. Make stake naming consistent Print which test is runned before run it (#1889) * Print which test is runned before run it * adding a timeout Add transaction to tx rpc (#1865) * Add transaction to tx rpc * address comments * fix Run test as non root in docker and check binary exist before mount to docker (#1891) * Run test as non root in docker, check is file before mount to docker Fix stake return for double sign slashing (#1877) Addressing comments & fixing fmt Improve naming for stats in the epoch manager. Fix some comments in restaking service Add test for restaked * Fixes
SkidanovAlex
pushed a commit
that referenced
this pull request
Jan 29, 2020
* Adding restaking tool. Modify RPC for validators to show produced/expected. Added author to Chunk and Block Validators RPC shows shards/pk, network info RPC shows peer ids for known validators. Make stake naming consistent Print which test is runned before run it (#1889) * Print which test is runned before run it * adding a timeout Add transaction to tx rpc (#1865) * Add transaction to tx rpc * address comments * fix Run test as non root in docker and check binary exist before mount to docker (#1891) * Run test as non root in docker, check is file before mount to docker Fix stake return for double sign slashing (#1877) Addressing comments & fixing fmt Improve naming for stats in the epoch manager. Fix some comments in restaking service Add test for restaked * Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When someone commits double sign, if their stake is not entirely slashed, the remaining stake should be returned back to them three epochs later.