[store] Remove genesis_height param from ChainStore::new() #12831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12831 +/- ##
=======================================
Coverage 70.37% 70.37%
=======================================
Files 848 848
Lines 174960 174870 -90
Branches 174960 174870 -90
=======================================
- Hits 123129 123072 -57
+ Misses 46575 46544 -31
+ Partials 5256 5254 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wacban
approved these changes
Jan 29, 2025
| genesis.transaction_validity_period, | ||
| ), | ||
| } | ||
| Self { chain_store: ChainStore::new(store, false, genesis.transaction_validity_period) } |
There was a problem hiding this comment.
If you can get rid of the transaction_validity_period we could remove genesis all together from here. Just saying ;)
shreyan-gupta
added a commit
to shreyan-gupta/nearcore
that referenced
this pull request
Mar 28, 2025
Part 2 of removing dependency of ChainStoreAdapter from genesis_height Follow up of PR near#12828 We can cleanup the interface of ChainStoreAdapter and we no longer need `genesis_height` and `save_trie_changes` as initialization params.
shreyan-gupta
added a commit
to shreyan-gupta/nearcore
that referenced
this pull request
Mar 28, 2025
Part 2 of removing dependency of ChainStoreAdapter from genesis_height Follow up of PR near#12828 We can cleanup the interface of ChainStoreAdapter and we no longer need `genesis_height` and `save_trie_changes` as initialization params.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of removing dependency of ChainStoreAdapter from genesis_height
Follow up of PR #12828
We can cleanup the interface of ChainStoreAdapter and we no longer need
genesis_heightandsave_trie_changesas initialization params.