-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bench(synth-bench): make binary selection more explicit #12817
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12817 +/- ##
==========================================
- Coverage 70.41% 70.40% -0.01%
==========================================
Files 848 848
Lines 174930 174930
Branches 174930 174930
==========================================
- Hits 123169 123166 -3
- Misses 46506 46509 +3
Partials 5255 5255
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment. Otherwise LGTM
Before the justfile would just use
target/release/neard
, which can be unexpected. Changes this and adds docs explaining how to set the binary used in benchmarks.