Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench(synth-bench): make binary selection more explicit #12817

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mooori
Copy link
Contributor

@mooori mooori commented Jan 28, 2025

Before the justfile would just use target/release/neard, which can be unexpected. Changes this and adds docs explaining how to set the binary used in benchmarks.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.40%. Comparing base (c625d98) to head (f3a642b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12817      +/-   ##
==========================================
- Coverage   70.41%   70.40%   -0.01%     
==========================================
  Files         848      848              
  Lines      174930   174930              
  Branches   174930   174930              
==========================================
- Hits       123169   123166       -3     
- Misses      46506    46509       +3     
  Partials     5255     5255              
Flag Coverage Δ
backward-compatibility 0.16% <ø> (ø)
db-migration 0.16% <ø> (ø)
genesis-check 1.41% <ø> (ø)
linux 70.02% <ø> (+<0.01%) ⬆️
linux-nightly 70.05% <ø> (ø)
pytests 1.70% <ø> (ø)
sanity-checks 1.52% <ø> (ø)
unittests 70.24% <ø> (-0.01%) ⬇️
upgradability 0.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mooori mooori marked this pull request as ready for review January 28, 2025 15:33
@mooori mooori requested a review from a team as a code owner January 28, 2025 15:33
Copy link
Contributor

@ssavenko-near ssavenko-near left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment. Otherwise LGTM

@ssavenko-near ssavenko-near self-requested a review January 29, 2025 08:12
benchmarks/synth-bm/justfile Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants