Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace EpochInfoProvider::account_id_to_shard_id with shar… #12754

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

ssavenko-near
Copy link
Contributor

@ssavenko-near ssavenko-near linked an issue Jan 17, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.72%. Comparing base (3d8336a) to head (a9a0bda).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
runtime/runtime/src/congestion_control.rs 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12754      +/-   ##
==========================================
+ Coverage   69.08%   70.72%   +1.64%     
==========================================
  Files         849      849              
  Lines      173954   174647     +693     
  Branches   173954   174647     +693     
==========================================
+ Hits       120174   123517    +3343     
+ Misses      48703    45959    -2744     
- Partials     5077     5171      +94     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (?)
db-migration 0.16% <0.00%> (?)
genesis-check 1.35% <0.00%> (?)
linux 69.18% <83.33%> (+0.09%) ⬆️
linux-nightly 70.32% <83.33%> (?)
pytests 1.65% <0.00%> (?)
sanity-checks 1.46% <0.00%> (?)
unittests 70.55% <83.33%> (+1.47%) ⬆️
upgradability 0.20% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssavenko-near ssavenko-near requested a review from wacban January 17, 2025 14:05
@ssavenko-near ssavenko-near marked this pull request as ready for review January 17, 2025 14:05
@ssavenko-near ssavenko-near requested a review from a team as a code owner January 17, 2025 14:05
Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

.account_id_to_shard_id(receiver_id, &self.epoch_id)
.expect("account_id_to_shard_id should never fail");
.shard_layout(&self.epoch_id)
.unwrap()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unwrap bothers me a little but it's not related to your PR. Please ignore unless you have any good ideas.

@ssavenko-near ssavenko-near added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@ssavenko-near ssavenko-near added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@ssavenko-near ssavenko-near added this pull request to the merge queue Jan 17, 2025
Merged via the queue into master with commit b6f82d6 Jan 17, 2025
28 checks passed
@ssavenko-near ssavenko-near deleted the slavas/12542-epoch-info-provider branch January 17, 2025 16:15
@ssavenko-near ssavenko-near linked an issue Jan 20, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EpochInfoProvider improvements
3 participants