-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace EpochInfoProvider::account_id_to_shard_id with shar… #12754
Conversation
…d_layout calls [issue 12542](#12542)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12754 +/- ##
==========================================
+ Coverage 69.08% 70.72% +1.64%
==========================================
Files 849 849
Lines 173954 174647 +693
Branches 173954 174647 +693
==========================================
+ Hits 120174 123517 +3343
+ Misses 48703 45959 -2744
- Partials 5077 5171 +94
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
.account_id_to_shard_id(receiver_id, &self.epoch_id) | ||
.expect("account_id_to_shard_id should never fail"); | ||
.shard_layout(&self.epoch_id) | ||
.unwrap() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This unwrap bothers me a little but it's not related to your PR. Please ignore unless you have any good ideas.
issue 12542