-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make indexer support single shard tracking. #12607
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12607 +/- ##
==========================================
+ Coverage 70.17% 70.48% +0.31%
==========================================
Files 840 845 +5
Lines 169987 172001 +2014
Branches 169987 172001 +2014
==========================================
+ Hits 119282 121239 +1957
- Misses 45632 45648 +16
- Partials 5073 5114 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@khorolets do we have any? |
No, we don't. I have no ideas what and how to test it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robin-near I'll have a closer look at the changes and get back to you. At a glance this way of tracking shards does not make sense to the indexer and its real life use cases.
cc @frol maybe you have something in your mind.
@khorolets thanks for taking a look! We need single-account tracking for the MPC (chain signatures) use case. We only care about the state of one account, and tracking all shards is a big waste of resources. |
f26b12e
to
266088a
Compare
Allow using tracked_accounts. In that case, use a ShardTracker to filter down the chunks we should query.
Is there any tests for the indexer? 🤔