fix: quick workaround for flat storage memtrie comparison #12592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wacban
approved these changes
Dec 10, 2024
Comment on lines
661
to
664
| if let FlatStorageStatus::Ready(status) = client | ||
| .chain | ||
| .runtime_adapter | ||
| .get_flat_storage_manager() |
There was a problem hiding this comment.
mini nit: you also need the manager a few lines below, maybe move to a variable
Longarithm
approved these changes
Dec 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12592 +/- ##
=======================================
Coverage 70.18% 70.18%
=======================================
Files 840 840
Lines 169987 169987
Branches 169987 169987
=======================================
+ Hits 119299 119304 +5
+ Misses 45621 45616 -5
Partials 5067 5067
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix to allow state comparison between flat storage and memtries only when the view over key value pairs is at the same height, for both of them.