Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: script for setting kernel tunables and check when running neard #12577

Merged
merged 10 commits into from
Dec 12, 2024

Conversation

stedfn
Copy link
Contributor

@stedfn stedfn commented Dec 9, 2024

Standalone script for setting the recommended networking settings on Linux and addition of a check when starting neard. If the settings are not right, errors will be printed without halting the process.

@stedfn stedfn self-assigned this Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 5.71429% with 33 lines in your changes missing coverage. Please review.

Project coverage is 70.20%. Comparing base (3270551) to head (1c08c53).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
neard/src/cli.rs 5.71% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12577      +/-   ##
==========================================
+ Coverage   70.02%   70.20%   +0.17%     
==========================================
  Files         840      840              
  Lines      169854   170141     +287     
  Branches   169854   170141     +287     
==========================================
+ Hits       118947   119445     +498     
+ Misses      45871    45630     -241     
- Partials     5036     5066      +30     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (-0.01%) ⬇️
db-migration 0.16% <0.00%> (?)
genesis-check 1.29% <0.00%> (?)
linux 69.42% <5.71%> (+0.10%) ⬆️
linux-nightly 69.79% <5.71%> (+0.01%) ⬆️
pytests 1.60% <0.00%> (+1.43%) ⬆️
sanity-checks 1.41% <0.00%> (?)
unittests 70.03% <5.71%> (+<0.01%) ⬆️
upgradability 0.20% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stedfn stedfn requested a review from akhi3030 December 11, 2024 11:52
@stedfn stedfn marked this pull request as ready for review December 11, 2024 11:52
@stedfn stedfn requested a review from a team as a code owner December 11, 2024 11:52
stedfn and others added 3 commits December 11, 2024 13:54
Co-authored-by: Razvan Barbascu <razvan@nearone.org>
Copy link
Contributor

@VanBarbascu VanBarbascu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff!

neard/src/cli.rs Outdated Show resolved Hide resolved
neard/src/cli.rs Outdated Show resolved Hide resolved
stedfn and others added 2 commits December 12, 2024 11:50
Co-authored-by: Akhilesh Singhania <akhi3030@gmail.com>
@stedfn stedfn enabled auto-merge December 12, 2024 09:52
@stedfn stedfn added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit 53503e8 Dec 12, 2024
22 checks passed
@stedfn stedfn deleted the stefan/kernel_tunables branch December 12, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants