cleanup(resharding) - remove new_shard_id_tmp #12272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trisfald
approved these changes
Oct 21, 2024
| // TODO(wacban) This is a temporary solution to aid the transition to having | ||
| // ShardId as a newtype. It should be replaced / removed / inlined once the | ||
| // transition is complete. | ||
| pub const fn new_shard_id_tmp(id: u64) -> ShardId { |
There was a problem hiding this comment.
nit: I noticed not all methods in impl ShardId are const while they probably could be.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12272 +/- ##
==========================================
- Coverage 71.58% 71.57% -0.02%
==========================================
Files 836 836
Lines 167470 167463 -7
Branches 167470 167463 -7
==========================================
- Hits 119891 119869 -22
- Misses 42347 42362 +15
Partials 5232 5232
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the remaining usages of new_shard_id_tmp and replacing it with ShardId::new. Removed the new_shard_id_tmp too.