Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: uncomment congestion_control.py #12021

Merged
merged 2 commits into from
Aug 30, 2024
Merged

chore: uncomment congestion_control.py #12021

merged 2 commits into from
Aug 30, 2024

Conversation

Longarithm
Copy link
Member

After Near-One/nayduck#58, 3 consecutive runs against master shows that slow_chunk and congestion_control pass now. So it is safe to uncomment congestion_control.py.

@Longarithm Longarithm requested a review from wacban August 29, 2024 18:54
@Longarithm Longarithm requested a review from a team as a code owner August 29, 2024 18:54
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.54%. Comparing base (ee5f317) to head (7a08394).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12021      +/-   ##
==========================================
+ Coverage   71.51%   71.54%   +0.03%     
==========================================
  Files         812      815       +3     
  Lines      164491   164661     +170     
  Branches   164491   164661     +170     
==========================================
+ Hits       117634   117808     +174     
+ Misses      41701    41691      -10     
- Partials     5156     5162       +6     
Flag Coverage Δ
backward-compatibility 0.23% <ø> (-0.01%) ⬇️
db-migration 0.23% <ø> (-0.01%) ⬇️
genesis-check 1.34% <ø> (-0.01%) ⬇️
integration-tests 38.51% <ø> (+0.08%) ⬆️
linux 71.22% <ø> (-0.05%) ⬇️
linux-nightly 71.10% <ø> (+<0.01%) ⬆️
macos 52.62% <ø> (-0.98%) ⬇️
pytests 1.60% <ø> (-0.01%) ⬇️
sanity-checks 1.40% <ø> (-0.01%) ⬇️
unittests 65.49% <ø> (+0.03%) ⬆️
upgradability 0.27% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again for fixing it!

Is that some whitespace changes at the end?

@Longarithm
Copy link
Member Author

Is that some whitespace changes at the end?

Yeah. VSCode added them automatically and then I've noticed that all other txt-s have the same ending already.

@Longarithm Longarithm added this pull request to the merge queue Aug 30, 2024
Merged via the queue into master with commit c90b9ad Aug 30, 2024
30 checks passed
@Longarithm Longarithm deleted the nayduck-debug branch August 30, 2024 17:31
staffik pushed a commit that referenced this pull request Sep 5, 2024
After Near-One/nayduck#58, 3 consecutive runs
against master shows that slow_chunk and congestion_control pass now. So
it is safe to uncomment congestion_control.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants