Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stateless_validation] Rename StateWitnessActor to PartialWitnessActor #11191

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

shreyan-gupta
Copy link
Contributor

Better organization of partial witness actor and actions. Renaming and pushing to a new module.

Only refactoring changes.

@shreyan-gupta shreyan-gupta requested a review from pugachAG April 30, 2024 22:42
@shreyan-gupta shreyan-gupta requested a review from a team as a code owner April 30, 2024 22:42
@shreyan-gupta shreyan-gupta added the A-stateless-validation Area: stateless validation label Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 93.50649% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 71.14%. Comparing base (408bc00) to head (3cd2132).

Files Patch % Lines
chain/network/src/peer/testonly.rs 0.00% 1 Missing and 1 partial ⚠️
chain/network/src/peer_manager/testonly.rs 0.00% 1 Missing and 1 partial ⚠️
chain/client/src/test_utils/test_env.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11191      +/-   ##
==========================================
- Coverage   71.15%   71.14%   -0.01%     
==========================================
  Files         783      783              
  Lines      155434   155438       +4     
  Branches   155434   155438       +4     
==========================================
- Hits       110594   110589       -5     
- Misses      40405    40419      +14     
+ Partials     4435     4430       -5     
Flag Coverage Δ
backward-compatibility 0.24% <0.00%> (-0.01%) ⬇️
db-migration 0.24% <0.00%> (-0.01%) ⬇️
genesis-check 1.41% <0.00%> (-0.01%) ⬇️
integration-tests 37.10% <93.50%> (+0.02%) ⬆️
linux 69.24% <63.63%> (+<0.01%) ⬆️
linux-nightly 70.58% <93.50%> (-0.03%) ⬇️
macos 53.05% <43.83%> (-0.02%) ⬇️
pytests 1.63% <0.00%> (-0.01%) ⬇️
sanity-checks 1.42% <0.00%> (-0.01%) ⬇️
unittests 65.75% <42.85%> (-0.01%) ⬇️
upgradability 0.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shreyan-gupta shreyan-gupta enabled auto-merge April 30, 2024 23:18
@shreyan-gupta shreyan-gupta added this pull request to the merge queue Apr 30, 2024
Merged via the queue into master with commit 2feec32 Apr 30, 2024
28 of 29 checks passed
@shreyan-gupta shreyan-gupta deleted the shreyan/stateless_validation/rename branch April 30, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-stateless-validation Area: stateless validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants