Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up FlatStateColumn #9044

Closed
pugachAG opened this issue May 10, 2023 · 0 comments · Fixed by #9051
Closed

Clean up FlatStateColumn #9044

pugachAG opened this issue May 10, 2023 · 0 comments · Fixed by #9051
Assignees
@jbajic
Labels
A-storage Area: storage and databases C-housekeeping Category: Refactoring, cleanups, code quality

Comments

@pugachAG
Copy link
Contributor

protocol_feature_flat_state no longer exists, so we we can just directly use DBCol::* enum.

The cleanup involves removing FlatStateColumn enum and directly inlining corresponding DBCol values instead of FlatStateColumn::to_db_col
@pugachAG pugachAG added C-housekeeping Category: Refactoring, cleanups, code quality A-storage Area: storage and databases labels May 10, 2023
@jbajic jbajic linked a pull request May 12, 2023 that will close this issue
refactor: Remove FlatStateColumn #9051
Merged
@jbajic jbajic mentioned this issue May 12, 2023
Merged
near-bulldozer bot pushed a commit that referenced this issue May 15, 2023
refactor: Remove FlatStateColumn (#9051)
48087bd 
Addresses issue #9044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbajic jbajic

Labels
A-storage Area: storage and databases C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Remove FlatStateColumn near/nearcore
2 participants
@pugachAG @jbajic