Make size limit of orphan witnesses configurable #10650
Assignees
Labels
A-stateless-validation
Area: stateless validation
C-good-first-issue
Category: issues that are self-contained and easy for newcomers to work on.
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Mar 22, 2024
…n config.json (#10847) Addresses a TODO in #10650. The default value is 40MB and currently represented as a constant MAX_ORPHAN_WITNESS_SIZE. This change replaces this constant with a config field named "orphan_state_witness_max_size." Example from generated config.json with init command: ``` ... "orphan_state_witness_pool_size": 25, "orphan_state_witness_max_size": 40000000 ```
|
Addressed in PR #10847. In config.json the orphan witness data size can be specified as follows: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The size of orphaned chunk state witnesses admitted to the
OrphanStateWitnessPoolis limited by the constantMAX_ORPHAN_WITNESS_SIZE. Value ofMAX_ORPHAN_WITNESS_SIZEwas chosen based on the observed values, but this estimation might not be perfect. If the limit turns out to be too small, it could lead to discarding valid orphaned witnesses. This isn't a big problem, but it could increase the number of missing chunks.It would be nice to allow node operators to control this limit from
config.json, just like it's possible to control the pool size by using theorphan_state_witness_pool_sizeconfig parameter.Refs: #10613 (comment)
The text was updated successfully, but these errors were encountered: