no early return

near · May 25, 2023 · e8cdc87 · e8cdc87
1 parent 1821685
commit e8cdc87
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/core/account-id/src/lib.rs b/core/account-id/src/lib.rs
@@ -379,17 +379,18 @@ impl<'a> arbitrary::Arbitrary<'a> for AccountId {
     fn arbitrary(u: &mut arbitrary::Unstructured<'a>) -> arbitrary::Result<Self> {
         let s = u.arbitrary::<&str>()?;
         match s.parse::<AccountId>() {
-            Ok(account_id) => return Ok(account_id),
+            Ok(account_id) => Ok(account_id),
             Err(e) => {
                 if let Some((valid_up_to, _)) = e.char {
                     let valid = &s[..valid_up_to];
                     debug_assert!(AccountId::validate(valid).is_ok());
                     #[allow(deprecated)]
-                    return Ok(AccountId::new_unvalidated(valid.to_string()));
+                    Ok(AccountId::new_unvalidated(valid.to_string()));
+                } else {
+                    Err(arbitrary::Error::IncorrectFormat)
                 }
             }
         }
-        Err(arbitrary::Error::IncorrectFormat)
     }
 
     fn arbitrary_take_rest(u: arbitrary::Unstructured<'a>) -> arbitrary::Result<Self> {