NEAR Explorer Russian translation #738
Conversation
|
Hello, @nebezgreshniy! |
|
@nebezgreshniy @dec0dOS Hey guys! Thanks for your contribution, you done well! I'll make a review soon |
There was a problem hiding this comment.
@nebezgreshniy Hey! You've done great job! Could you please address the comments to finish this task?
|
@shelegdmitriy @frol @telezhnaya |
|
For review convenience, I have deployed the version of Explorer UI with this PR included for preview: https://near-explorer-frontend-with-indexer-temp.onrender.com/ (I had to push a new branch on the upstream repo to be able to deploy it, so we will need to push updates to |
|
Sorry if I duplicate comments
|
|
It seems that the Vietnamese version also has not translated the datetimes |
|
@dec0dOS @nebezgreshniy Hey guys! We have a separate channel for discussing all the things. Please join https://t.me/near_explorer_ru_ch for discussing 😀 |
| }, | ||
| "AddKey": { | ||
| "new_key_added": "Добавлен новый ключ для ", | ||
| "with_permission_and_nounce": "с разрешением ${permission} и одноразовым номером ${nonce}", |
There was a problem hiding this comment.
| "with_permission_and_nounce": "с разрешением ${permission} и одноразовым номером ${nonce}", | |
| "with_permission_and_nounce": "с разрешением ${permission}", |
We decided to remove this part of translation. It would be great to remove this staff from other translation files (en, vi, zn-hans)
| "new_key_added": "Добавлен новый ключ для ", | ||
| "with_permission_and_nounce": "с разрешением ${permission} и одноразовым номером ${nonce}", | ||
| "access_key_added_for_contract": "Ключ доступа добавлен для контракта ", | ||
| "with_permission_call_method_and_nounce": "с разрешением для вызова ${methods} методов с одноразовым номером ${nonce}", |
There was a problem hiding this comment.
There was a problem hiding this comment.
@nebezgreshniy Hey there! I think I'm done with all breakpoints so I'll be waiting for your commit 😀
|
@think-in-universe Hey! I want to ask you whether there was some specific reason we did not use the official moment.js locales: https://github.com/moment/moment/tree/develop/locale. I would love to switch using those instead of duplicating that effort for every translation on Explorer |
frontend/src/libraries/language.js
Outdated
| case "zn-hans": | ||
| locale = "zn-hans"; |
There was a problem hiding this comment.
| case "zn-hans": | |
| locale = "zn-hans"; | |
| case "zh-hans": | |
| locale = "zh-cn"; |
| receipt.status ? ( | ||
| <ReceiptExecutionStatus status={receipt.status} /> | ||
| ) : ( | ||
| <>{"Fetching Status..."}</> |
There was a problem hiding this comment.
Must be translated too. We already have such translation here
. You could place it here and use in component| "ReceiptAction": { | ||
| "batch_receipt": "Batch Receipt" | ||
| } |
There was a problem hiding this comment.
| "ReceiptAction": { | |
| "batch_receipt": "Batch Receipt" | |
| } | |
| "ReceiptAction": { | |
| "batch_receipt": "Batch Receipt", | |
| "fetching_status": "Fetching Status..." | |
| } |
Don't forget to do the same for other files. We already have a translations for "fetching_status"
|
This issue was closed by mistake. See #762 |
This PR resolves near/bounties#63