-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2379 suggestions #2457
Merged
bucanero
merged 10 commits into
2379-doc-improve-chain-abstraction-overview
from
2379-suggestions
Feb 5, 2025
Merged
2379 suggestions #2457
bucanero
merged 10 commits into
2379-doc-improve-chain-abstraction-overview
from
2379-suggestions
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisjoshford
added a commit
that referenced
this pull request
Feb 5, 2025
* update * Update what-is.md * Update docs/2.build/1.chain-abstraction/what-is.md Co-authored-by: Josh Ford <thisisjoshford@gmail.com> * update * Update what-is.md * Update what-is.md * Update what-is.md * diagram * 2379 suggestions (#2457) * fix: simplify intro & overview * feat: expand upon what is CA * feat: enhance intent/solver layer * feat: improve chain sig section * feat: improve omnibridge section * fix: remove duplicate section * fix: remove realyers * fix: remove use-cases -> locate elsewhere * fix: rethink intro based on article updates * fix: minor edits --------- Co-authored-by: Josh Ford <thisisjoshford@gmail.com>
thisisjoshford
added a commit
that referenced
this pull request
Feb 11, 2025
* fix: update near logo (#2453) * Add Lantstool examples for RPC - Access Keys (#2456) * Chain abstraction overview update (#2420) * update * Update what-is.md * Update docs/2.build/1.chain-abstraction/what-is.md Co-authored-by: Josh Ford <thisisjoshford@gmail.com> * update * Update what-is.md * Update what-is.md * Update what-is.md * diagram * 2379 suggestions (#2457) * fix: simplify intro & overview * feat: expand upon what is CA * feat: enhance intent/solver layer * feat: improve chain sig section * feat: improve omnibridge section * fix: remove duplicate section * fix: remove realyers * fix: remove use-cases -> locate elsewhere * fix: rethink intro based on article updates * fix: minor edits --------- Co-authored-by: Josh Ford <thisisjoshford@gmail.com> * feat: reorg omnibridge docs and add hackmd content * fix: update omnibridge overview and consolidate into one file --------- Co-authored-by: Volodymyr Bilyk <eclipseeer@gmail.com> Co-authored-by: Damián Parrino <bucanero@users.noreply.github.com>
thisisjoshford
added a commit
that referenced
this pull request
Feb 13, 2025
* Create omnibridge.svg * add omnibridge * 2430 suggestions (#2461) * fix: update near logo (#2453) * Add Lantstool examples for RPC - Access Keys (#2456) * Chain abstraction overview update (#2420) * update * Update what-is.md * Update docs/2.build/1.chain-abstraction/what-is.md Co-authored-by: Josh Ford <thisisjoshford@gmail.com> * update * Update what-is.md * Update what-is.md * Update what-is.md * diagram * 2379 suggestions (#2457) * fix: simplify intro & overview * feat: expand upon what is CA * feat: enhance intent/solver layer * feat: improve chain sig section * feat: improve omnibridge section * fix: remove duplicate section * fix: remove realyers * fix: remove use-cases -> locate elsewhere * fix: rethink intro based on article updates * fix: minor edits --------- Co-authored-by: Josh Ford <thisisjoshford@gmail.com> * feat: reorg omnibridge docs and add hackmd content * fix: update omnibridge overview and consolidate into one file --------- Co-authored-by: Volodymyr Bilyk <eclipseeer@gmail.com> Co-authored-by: Damián Parrino <bucanero@users.noreply.github.com> * fix: move to omnibridge directory * fix: update architecture description & chain sig link * fix: update intro and add background * feat: enhance background * feat: separate implementation and roadmap into separate docs * fix: update omni bridge overview in what-is chain abstraction * fix: update what-is and implementation * change path * Apply suggestions from code review * Update how-it-works.md * Delete website/static/docs/assets/omnibridge.svg * feat: add more references to SDK for higher visibility * fix: add improvement suggestions * fix: infeasible -> impossible --------- Co-authored-by: Josh Ford <thisisjoshford@gmail.com> Co-authored-by: Volodymyr Bilyk <eclipseeer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @bucanero, I started to review your PR making some suggestions but found the structure needed some overhaul as we are making a significant update to this overview (focusing on intents / chain sig / omnibridge)
I also removed the overview graphic for now and think we should rethink it. Omnibridge actually uses chain signatures in its implementation so having it be its own section outside of it didn't fully make sense to me. Happy to discuss this more and come up with some alternatives we can include later.