Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor for .editorconfig #7

Closed
angelozerr opened this issue Jul 17, 2015 · 13 comments
Closed

Editor for .editorconfig #7

angelozerr opened this issue Jul 17, 2015 · 13 comments

Comments

@angelozerr
Copy link
Contributor

It should be cool if you could provide an editor with syntax coloration validation completion for .editorconfig

@paulvi
Copy link

paulvi commented Sep 1, 2015

👍

The format is actually similar to properties file and similar for .git* files

I can create an Editor based on simple TextEditor,
https://github.com/Nodeclipse/org.nodeclipse.gitaddon/blob/master/gitaddon.core/plugin.xml#L6-L16

but I don't know feature id for Eclipse Properties Editor Nodeclipse/org.nodeclipse.gitaddon#4

paulvi pushed a commit to paulvi/editorconfig-eclipse that referenced this issue Sep 2, 2015
ncjones added a commit that referenced this issue Sep 2, 2015
ref #7 TextEditor-based Editor
@ncjones
Copy link
Owner

ncjones commented Sep 2, 2015

@paulvi thanks for the submission of the basic editor. I'll leave this issue open because it is really about providing syntax highlighting, validation and auto completion.

@paulvi
Copy link

paulvi commented Sep 2, 2015

@ncjones exactly, otherwise I could close from commit

Once we know feature id for Eclipse Properties Editor, we possibly can extend its Class

@paulvi
Copy link

paulvi commented Sep 2, 2015

@angelozerr
Copy link
Contributor Author

IMHO I think we should create from scratch this editor to highlight section name too. More we will avoid having dependencies to JDT (id is org.eclipse.jdt.ui.PropertiesFileEditor)

@ncjones
Copy link
Owner

ncjones commented Sep 2, 2015

Maybe look at XText.

@angelozerr
Copy link
Contributor Author

XText is very powerful, but you add a new (big) dependencies just to support basic features that I think we could develop at hand. It's just my opinion.

@paulvi
Copy link

paulvi commented Sep 2, 2015

From what I worked with Nodeclipse has JS Editor, that became base for Gradle Editor, quite simple https://github.com/Nodeclipse/nodeclipse-1/tree/master/org.nodeclipse.enide.editors.gradle

And Markdown Editor https://github.com/winterstein/Eclipse-Markdown-Editor-Plugin

Then there are bigger projects like PyDev, Aptana

But you better look at examples like YEdit (YAML Editor)

@angelozerr
Copy link
Contributor Author

I have started to implement the editorconfig editor with syntax coloration (like Properties File Editor) by soing several copy/paste from JSDT Properties File editor. Here the result:

editorconfigeditor

If you wish a contribution, tell me, but I think we should refactor a lot your plugin like split into 2 plugins (core.ui), etc

@mickaelistria
Copy link

@angelozerr: +1 for such an editor.

@ncjones
Copy link
Owner

ncjones commented May 25, 2016

@angelozerr very cool

@angelozerr
Copy link
Contributor Author

@ncjones see PR #38

@angelozerr
Copy link
Contributor Author

The EditorConfigEditor is now in the master (see accept of PR #38). It supports syntax coloration for the moment, but I will improve it again (completion support, validation, etc).

I close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants