Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on 32bit arch #210

Merged
merged 1 commit into from
Oct 31, 2021
Merged

Fix on 32bit arch #210

merged 1 commit into from
Oct 31, 2021

Conversation

c0va23
Copy link
Contributor

@c0va23 c0va23 commented Oct 31, 2021

Hi, latest version (0.7.8) of this exporter cannot collect proc stat on armv6 (and posible on all other 32 bit platform). Its bug into currently used procfs package, but in last version bug fixed.

Updating procfs package fix this exporter for 32 bit platforms. I tested fix on my armv7 device, after this patch - exporter start working.

This changes fix bug:
prometheus/procfs@v0.7.1...v0.7.3#diff-a1d7bdae8a86539cbde035eaa8ddef778467c826d849ac33a4ec56b067091695R130-R183

Logs before path:

Oct 31 10:43:18 radxa.lan process-exporter[3950]: 2021/10/31 10:43:18 error getting proc ID for pid 613: integer overflow on token 3069030400
Oct 31 10:43:18 radxa.lan process-exporter[3950]: 2021/10/31 10:43:18 error getting proc ID for pid 614: integer overflow on token 3069030400
Oct 31 10:43:18 radxa.lan process-exporter[3950]: 2021/10/31 10:43:18 error getting proc ID for pid 615: integer overflow on token 3069030400

Logs after path:

Oct 31 10:44:20 radxa.lan process-exporter[4362]: 2021/10/31 10:44:20 found new proc: {Pid:1 StartTimeRel:4}:{Name:systemd Cmdline:[/sbi
n/init] Cgroups:[/ / / /init.scope] ParentPid:0 StartTime:2021-10-19 23:48:53.04 +0000 UTC EffectiveUID:0}
Oct 31 10:44:20 radxa.lan process-exporter[4362]: 2021/10/31 10:44:20 found new proc: {Pid:2 StartTimeRel:4}:{Name:kthreadd Cmdline:[] C
groups:[/ / / /] ParentPid:0 StartTime:2021-10-19 23:48:53.04 +0000 UTC EffectiveUID:0}
Oct 31 10:44:20 radxa.lan process-exporter[4362]: 2021/10/31 10:44:20 found new proc: {Pid:3 StartTimeRel:8}:{Name:ksoftirqd/0 Cmdline:[
] Cgroups:[/ / / /] ParentPid:2 StartTime:2021-10-19 23:48:53.08 +0000 UTC EffectiveUID:0}

Fix collect proc stat on armv6
@ncabatoff ncabatoff merged commit b7310f0 into ncabatoff:master Oct 31, 2021
@ncabatoff
Copy link
Owner

Thanks @c0va23 ! v0.7.9 contains this fix.

@c0va23 c0va23 deleted the feature/fix-arm32bit branch November 1, 2021 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants