Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/json serialization #90

Merged
merged 3 commits into from
Mar 6, 2023

Conversation

arielshulman
Copy link
Contributor

@arielshulman arielshulman commented Mar 2, 2023

Hey,
As discussed in #88 issue, I've made a quick fix which enable JSON serialization.
Some quick notes -

  1. I've created new initialJson and onJsonChange props to the component.
  2. I've added a new onImportError which I think should unify import errors and replace onImportXmlError.
  3. I didn't treat odd situations when someone used initialJson and initialXml simultaneously .
  4. The onJsonChange is executed based on the current mechanism which depends on xml changes.

What do you think?

Copy link
Owner

@nbudin nbudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for doing this @arielshulman! This all looks good to me, and I agree with consolidating the import error callbacks. Assuming the CI checks pass, I'll merge and release this.

@nbudin nbudin merged commit 4171769 into nbudin:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants