Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatibility for Blockly 10.0 #100

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Added compatibility for Blockly 10.0 #100

merged 2 commits into from
Jul 28, 2023

Conversation

oszizsolt
Copy link

Starting with Blockly 10.0, Blockly.Xml.textToDom is moved to Blockly.utils.xml.textToDom (google/blockly#6818). Due to this change, react-blockly failed to load the xml provided in initialXml. This pull request is a fix to this issue.

This will not work on older versions of blockly, so I've also updated blockly's version in package.json.

@nbudin
Copy link
Owner

nbudin commented Jul 28, 2023

Thanks @oszizsolt, much appreciated! Since this tightens the Blockly version requirement, I'll release this as a major version.

@nbudin nbudin merged commit 2a9ee4f into nbudin:main Jul 28, 2023
@oszlanyikornel
Copy link

Hey @oszizsolt,

Huge thanks for the pull request! I've been eagerly waiting for this change, and you've exceeded my expectations. Looking forward to more of your contributions in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants