Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/master' into 2019-08-09-preview
Browse files Browse the repository at this point in the history
  • Loading branch information
ctaggart committed Feb 4, 2020
2 parents 74392a8 + b91c2b9 commit 48cbe58
Show file tree
Hide file tree
Showing 6,957 changed files with 909,440 additions and 62,083 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
1,123 changes: 575 additions & 548 deletions .azure-pipelines-preproduction/package-lock.json

Large diffs are not rendered by default.

12 changes: 8 additions & 4 deletions .azure-pipelines-preproduction/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,22 @@
"description": "Tests for Azure REST API Specifications",
"license": "MIT",
"devDependencies": {
"@azure/avocado": "^0.6.0",
"@azure/rest-api-specs-scripts": "^0.5.1",
"@azure/avocado": "^0.6.2",
"@azure/rest-api-specs-scripts": "^0.5.7",
"@ts-common/commonmark-to-markdown": "^1.2.0",
"@ts-common/fs": "0.2.0",
"@ts-common/iterator": "^0.3.6",
"@types/js-yaml": "^3.12.1",
"@types/mocha": "^5.2.6",
"cspell": "^4.0.12",
"@types/prettier": "^1.18.3",
"cspell": "^4.0.30",
"js-yaml": "^3.13.1",
"json-schema-ref-parser": "^6.1.0",
"mocha": "*",
"ts-node": "^8.1.0",
"tslib": "^1.10.0",
"typescript": "3.5.3"
"typescript": "3.5.3",
"prettier": "^1.18.2"
},
"homepage": "https://github.com/azure/azure-rest-api-specs",
"repository": {
Expand All @@ -36,6 +38,8 @@
"scripts": {
"test": "tsc && mocha -t 500000 --reporter min",
"spellcheck": "ts-node ./scripts/spellcheck.ts",
"prettier-check": "tsc && ts-node ./scripts/prettier-check.ts",
"prettier": "prettier",
"tsc": "tsc",
"multiapi": "ts-node ./scripts/multiapi.ts"
}
Expand Down
4 changes: 3 additions & 1 deletion .azure-pipelines/ModelValidation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ jobs:
vmImage: 'Ubuntu 16.04'
steps:
- task: Npm@1
displayName: 'npm install'
displayName: 'npm ci'
inputs:
command: custom
verbose: false
customCommand: ci
- script: 'npm run tsc && node scripts/modelValidation.js'
displayName: 'Model Validation'
2 changes: 1 addition & 1 deletion .azure-pipelines/NetworkValidation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
displayName: Bypass Strong Name validation
- task: NodeTool@0
inputs:
versionSpec: 10.x
versionSpec: '10.16.3'
displayName: Install Node.js
- script: npm install autorest -g
displayName: Install autorest
Expand Down
15 changes: 15 additions & 0 deletions .azure-pipelines/PrettierCheck.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
jobs:
- job: "PrettierCheck"
condition: "not(variables['PRIVATE'])"
variables:
NODE_OPTIONS: '--max-old-space-size=8192'
pool:
vmImage: 'Ubuntu 18.04'
continueOnError: true
steps:
- task: Npm@1
displayName: 'npm install'
inputs:
verbose: false
- script: 'npm run prettier-check'
displayName: 'Run Prettier Check'
55 changes: 55 additions & 0 deletions .azure-pipelines/SDKAutomation.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
trigger:
batch: false
branches:
include:
- "*"

jobs:
- job: "SDKAutomation"
displayName: SDK
pool:
vmImage: 'Ubuntu 18.04'
container:
image: azopenapi.azurecr.io/openapi/sdk-automation:prod
endpoint: azopenapi-registry
timeoutInMinutes: 180

variables:
NODE_OPTIONS: '--max-old-space-size=8192'
BLOB_STORAGE_PREFIX: sdkautomation-pipeline
SPEC_REPO: $(Build.Repository.Name)
PR_NUMBER: $(System.PullRequest.PullRequestNumber)
strategy:
matrix:
Net:
SDK_REPO_NAME: azure-sdk-for-net
Java:
SDK_REPO_NAME: azure-sdk-for-java
JavaScript:
SDK_REPO_NAME: azure-sdk-for-js
Python:
SDK_REPO_NAME: azure-sdk-for-python
Go:
SDK_REPO_NAME: azure-sdk-for-go
steps:
- checkout: none
- script: printenv
displayName: Display ENV
- script: git config --global user.email "sdkautomation@microsoft.com" && git config --global user.name "SDK Automation"
displayName: Configure Git
- script: |
curl \
-s https://api.github.com/repos/$(Build.Repository.Name)/commits/$(Build.SourceVersion)/pulls \
-H "Accept: application/vnd.github.groot-preview+json" \
| python3 -c "import sys,json; a=json.load(sys.stdin); print(f'##vso[task.setvariable variable=PR_NUMBER]{a[0][\"number\"]}' if len(a)>0 and a[0][\"base\"][\"ref\"]=='master' else '##vso[task.logissue type=error]Last commit $(Build.SourceVersion) doesnot have a related PR')"
displayName: Get PR_NUMBER
condition: in(variables['Build.Reason'], 'IndividualCI', 'Manual')
- script: sudo chown `id -ng`:`id -ng` . && npm start
env:
BLOB_STORAGE_NAME: $(blob-storage-name)
BLOB_STORAGE_KEY: $(blob-storage-key)
GITHUB_COMMENT_AUTHOR_NAME: $(github-comment-author-name)
GITHUBAPP_ID: $(githubapp-id)
GITHUBAPP_PRIVATE_KEY: $(githubapp-private-key)
displayName: SDK Automation
workingDirectory: /z
4 changes: 3 additions & 1 deletion .azure-pipelines/Semantic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ jobs:
vmImage: 'Ubuntu 16.04'
steps:
- task: Npm@1
displayName: 'npm install'
displayName: 'npm ci'
inputs:
command: custom
verbose: false
customCommand: ci
- script: 'npm run tsc && node scripts/semanticValidation.js'
displayName: 'Semantic Validation'
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<i>MSFT employees can try out our new experience at <b>[OpenAPI Hub](https://aka.ms/openapiportal) </b> - one location for using our validation tools and finding your workflow.
</i><br>
### Contribution checklist:
- [ ] I have reviewed the [documentation](https://github.com/Azure/azure-rest-api-specs#basics) for the workflow.
- [ ] I have reviewed the [documentation](https://github.com/Azure/adx-documentation-pr/wiki/Overall-basic-flow) for the workflow.
- [ ] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR.
- [ ] The [OpenAPI Hub](https://aka.ms/openapiportal) was used for checking validation status and next steps.
### ARM API Review Checklist
Expand Down
2 changes: 0 additions & 2 deletions .github/reviewer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
- group:
name: default
users:
- githubID: ruowan
email: ruowan@microsoft.com
- githubID: raych1
email: raychen@microsoft.com
- githubID: MyronFanQiu
Expand Down
57 changes: 40 additions & 17 deletions .github/sla.yml
Original file line number Diff line number Diff line change
@@ -1,25 +1,48 @@
---
- scheduleTask:
action: sendEmailToAssignee
repoWhitelist:
- Azure/azure-rest-api-specs
scope: pull_request
args:
ignoredLabels:
- WaitForARMFeedback
- DoNotMerge
- WaitingForAzureAPIBoard
booleanFilterExpression: "!(WaitForARMFeedback||(DoNotMerge&&(ARMSignedOff||Approved)))"
limit: 48h
message: '<p> Dear Swagger reviewer, <br> <br> Please response to the PR ${PR_URL}. The PR isn''t updated in 48 hours. <br> <hr /> <br> Quick info. <ul> <li>If no response from ARM review board, please send email to armapireview@microsoft.com.</li> <li>If need immediate ARM review, please get ARM review oncall contact point from ICM https://icm.ad.msft.net/imp/v3/oncall/current under Service "Azure Resource Manager" and Team "RP Manifest Approvers"</li> <li>If no response from Azure API review board, please send email to azureapirbcore@microsoft.com.</li> <li>If you have problem to fix CI task errors, please send email to Visual Studio China Swagger and Tool team vscswagger@microsoft.com.</li> <li>If you want to opt out from Swagger reviewing for out of office period, please set vacation date at https://inframonitorweb1.azurewebsites.net/Home/MyView.</li> <li>Pls refer to <a href="onenote:https://microsoft.sharepoint.com/teams/IoTToolingTeam/SiteAssets/IoT Tooling Team Notebook/Azure Management Experience - transition.one#Swagger%20reviewing%20process§ion-id={ECE847C4-519B-4448-A1A0-8E84A7EFE8AB}&page-id={F6E345FE-46E1-420F-B837-6BF76167DE05}&end">Swagger review process (onenote)</a> for more about Swagger review process.</li> </ul> Best regards, <br> Azure Management Experience </p>'
subject: "Action Required: Please respond to PR ${PR_URL}"
description: "None initial response in 48 hours"
name: no-initial-response
message: '<p> Dear Swagger reviewer, <br> <br> Please response to the PR ${URL} . The PR isn''t updated in 48 hours. <br> <hr /> <br> Quick info. <ul> <li>If no response from ARM review board, please send email to armapireview@microsoft.com.</li> <li>If need immediate ARM review, please get ARM review oncall contact point from ICM https://icm.ad.msft.net/imp/v3/oncall/current under Service "Azure Resource Manager" and Team "RP Manifest Approvers"</li> <li>If no response from Azure API review board, please send email to azureapirbcore@microsoft.com.</li> <li>If you have problem to fix CI task errors, please send email to Visual Studio China Swagger and Tool team vscswagger@microsoft.com.</li> <li>If you want to opt out from Swagger reviewing for out of office period, please set vacation date at https://inframonitorweb1.azurewebsites.net/Home/MyView.</li> <li>Pls refer to <a href="onenote:https://microsoft.sharepoint.com/teams/IoTToolingTeam/SiteAssets/IoT Tooling Team Notebook/Azure Management Experience - transition.one#Swagger%20reviewing%20process§ion-id={ECE847C4-519B-4448-A1A0-8E84A7EFE8AB}&page-id={F6E345FE-46E1-420F-B837-6BF76167DE05}&end">Swagger review process (onenote)</a> for more about Swagger review process.</li> </ul> Best regards, <br> Azure Management Experience </p>'
subject: "Action Required: Please respond to PR ${URL}"
description: "None initial response in 48 hours. For public repo."
name: "[PUBLIC] initial response notification"

- scheduleTask:
action: sendEmailToAssignee
repoWhitelist:
- Azure/azure-rest-api-specs-pr
scope: pull_request
args:
ignoredLabels:
- WaitForARMFeedback
- DoNotMerge
- WaitingForAzureAPIBoard
limit: 5d
message: '<p> Dear Swagger reviewer, <br> <br> Please response to the PR ${PR_URL}. The PR isn''t updated in 5 days. <br> <hr /> <br> Quick info. <ul> <li>If no response from ARM review board, please send email to armapireview@microsoft.com.</li> <li>If need immediate ARM review, please get ARM review oncall contact point from ICM https://icm.ad.msft.net/imp/v3/oncall/current under Service "Azure Resource Manager" and Team "RP Manifest Approvers"</li> <li>If no response from Azure API review board, please send email to azureapirbcore@microsoft.com.</li> <li>If you have problem to fix CI task errors, please send email to Visual Studio China Swagger and Tool team vscswagger@microsoft.com.</li> <li>If you want to opt out from Swagger reviewing for out of office period, please set vacation date at https://inframonitorweb1.azurewebsites.net/Home/MyView.</li> <li>Pls refer to <a href="onenote:https://microsoft.sharepoint.com/teams/IoTToolingTeam/SiteAssets/IoT Tooling Team Notebook/Azure Management Experience - transition.one#Swagger%20reviewing%20process§ion-id={ECE847C4-519B-4448-A1A0-8E84A7EFE8AB}&page-id={F6E345FE-46E1-420F-B837-6BF76167DE05}&end">Swagger review process (onenote)</a> for more about Swagger review process.</li> </ul> Best regards, <br> Azure Management Experience </p>'
subject: "Action Required: Please respond to PR ${PR_URL}"
description: "None update in PR in 5 days"
name: no-update-in-5d
booleanFilterExpression: "!(WaitForARMFeedback||Approved-OkToMerge||(DoNotMerge&&(ARMSignedOff||Approved)))"
limit: 48h
message: '<p> Dear Swagger reviewer, <br> <br> Please response to the PR ${URL} . The PR isn''t updated in 48 hours. <br> <hr /> <br> Quick info. <ul> <li>If no response from ARM review board, please send email to armapireview@microsoft.com.</li> <li>If need immediate ARM review, please get ARM review oncall contact point from ICM https://icm.ad.msft.net/imp/v3/oncall/current under Service "Azure Resource Manager" and Team "RP Manifest Approvers"</li> <li>If no response from Azure API review board, please send email to azureapirbcore@microsoft.com.</li> <li>If you have problem to fix CI task errors, please send email to Visual Studio China Swagger and Tool team vscswagger@microsoft.com.</li> <li>If you want to opt out from Swagger reviewing for out of office period, please set vacation date at https://inframonitorweb1.azurewebsites.net/Home/MyView.</li> <li>Pls refer to <a href="onenote:https://microsoft.sharepoint.com/teams/IoTToolingTeam/SiteAssets/IoT Tooling Team Notebook/Azure Management Experience - transition.one#Swagger%20reviewing%20process§ion-id={ECE847C4-519B-4448-A1A0-8E84A7EFE8AB}&page-id={F6E345FE-46E1-420F-B837-6BF76167DE05}&end">Swagger review process (onenote)</a> for more about Swagger review process.</li> </ul> Best regards, <br> Azure Management Experience </p>'
subject: "Action Required: Please respond to PR ${URL}"
description: "None initial response in 48 hours. For private repo."
name: "[PRIVATE] initial response notification"

- scheduleTask:
action: sendEmail
scope: pull_request
args:
booleanFilterExpression: "(WaitForARMFeedback&&!ARMSignedOff&&!ARMChangesRequested&&!ARMReviewInProgress)"
limit: 3d
subject: "Action Required: Please help to review PR ${URL}"
message: "<p> Dear ARM review board, <br> <br>Please review PR ${URL} , the PR is waiting for ARM review over 3 days. Thanks.<br><hr /> <br>Quick info<ul><li>If you have feedback about the notification email, please contact us at vscswagger@microsoft.com.</li><li>After reviewing, please remove “WaitForARMFeedback” label from PR to avoid receiving notification on the same PR.</li><li>Please do not reply to this email, this is an automatic generated email.</li></ul>Best regards,<br> Azure Management Experience</p>"
to: armapireview@microsoft.com
description: "send email to ARM team for over 5 days PRs labelled with WaitForARMFeedback"
name: "send email to ARM team"

- scheduleTask:
action: sendEmailToAssignee
scope: issue
args:
booleanFilterExpression: "triage"
limit: 48h
message: "<p> Dear Swagger reviewer, <br> <br> Please response to the issue ${URL} . The issue isn't updated in 48 hours. <br> <hr /> <br> Quick info. <ul> <li>If you have any question, please send email to Visual Studio Swagger and Tool team vscswagger@microsoft.com.</li> </ul> Best regards, <br> Azure Management Experience </p>"
subject: "Action Required: Please respond to issue ${URL}"
cc: Ankun.Ning@microsoft.com
5 changes: 5 additions & 0 deletions .prettierrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"plugins": ["./scripts/prettier-swagger-plugin"],
"parser": "json-swagger",
"printWidth": 20
}
6 changes: 0 additions & 6 deletions .vscode/extensions.json

This file was deleted.

27 changes: 0 additions & 27 deletions .vscode/launch.json

This file was deleted.

24 changes: 0 additions & 24 deletions .vscode/settings.json

This file was deleted.

11 changes: 6 additions & 5 deletions CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
/specification/batchai/ @alexanderyukhanov
/specification/billing/ @wilcobmsft
/specification/cdn/ @csmengwan @injyzarif @prakharsharma10
/specification/cognitiveservices/ @davidlicig @felixwa @yangyuan
/specification/compute/ @huangpf @hyonholee
/specification/cognitiveservices/ @felixwa @yangyuan
/specification/compute/ @hyonholee @mabhard @danielli90 @smotwani @ppatwa @vikramd-ms @savyasachisamal @yunusm @ZhidongPeng @nkuchta @maheshnemichand @najams @changov
/specification/consumption/ @kjeur @panda-wang
/specification/containerinstance/ @samkreter
/specification/containerregistry/ @djyou
Expand Down Expand Up @@ -39,11 +39,11 @@
/specification/machinelearning/ @nonstatic2014
/specification/machinelearningcompute/ @shutchings
/specification/managementpartner/ @jeffrey-ace
/specification/mediaservices/ @brianblum
/specification/mediaservices/ @giakas
/specification/mobileengagement/ @pshrosbree
/specification/monitor/ @gucalder
/specification/mysql/ @qingqingyuan
/specification/network/ @MikhailTryakhov @number213
/specification/network/ @MikhailTryakhov @number213 @solhaile @v-shhatt
/specification/notificationhubs/ @amolr @smithab
/specification/operationalinsights/ @sw47
/specification/operationsmanagement/ @dashimi16
Expand All @@ -58,7 +58,8 @@
/specification/relay/ @sethmanheim @v-ajnava
/specification/resources/ @Tiano2017 @rajshah11 @vivsriaus
/specification/scheduler/ @pinwang81
/specification/search/ @brjohnstmsft
/specification/search/data-plane/ @brjohnstmsft @arv100kri @bleroy
/specification/search/resource-manager/ @abhi1509 @miwelsh @tjacobhi
/specification/serialconsole/ @amitchat @craigw @asinn826
/specification/service-map/ @daveirwin1
/specification/servicebus/ @sazeesha @v-ajnava
Expand Down
8 changes: 5 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@
This repository is the canonical source for REST API specifications for Microsoft Azure.

## Getting started
If you're a spec author looking for information about all of the repositories and steps in the pipeline, go to our [documentation](https://github.com/Azure/adx-documentation-pr/wiki) repository. Make sure to [join the Github Azure organization](http://aka.ms/azuregithub) to get access to that repo.
If you're a Microsoft employee looking for information about all of the repositories and steps in the pipeline, go to our [documentation](https://github.com/Azure/adx-documentation-pr/wiki) repository. Make sure to [join the Github Azure organization](http://aka.ms/azuregithub) to get access to that repo.

<b>Latest improvement:</b><i> Microsoft employees can try out our new experience at [OpenAPI Hub](https://aka.ms/openapihub) - online experience for using our validation tools and finding your workflow.</i>

External Contributors can get started [here](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Getting%20started%20with%20OpenAPI%20specifications.md)

Please check the [announcements page](https://github.com/Azure/azure-rest-api-specs/wiki/Announcements) for any new updates since your last visit.

## Directory Structure
Expand All @@ -17,7 +19,7 @@ The structure of the directory should strictly follow these rules:

1. **Profile**: The profile holder contains the profiles' definition MD files. these files will contain information and references to the snapshots of the RPs' Resource types or Dataplane API versions that represent a specific profile.

1. **Specification**: This folder the is root folder for all Specs (Management and Dataplane) related docs.
1. **Specification**: This folder is the root folder for all Specs (Management and Dataplane) related docs.

1. **{RP-Name} Folders** - each RP will have a separate folder

Expand Down Expand Up @@ -80,7 +82,7 @@ The structure should appear like so:
Currently, the specifications are expected to be in Swagger JSON format

## Next steps
The next step in the process after a spec is completed is to generate SDKs and API reference documentation. Go to the [Azure Developer Experience guide](https://github.com/Azure/adx-documentation-pr) for more information.
The next step in the process after a spec is completed is to generate SDKs and API reference documentation. If you're Microsoft employee, go to the [Azure Developer Experience guide](https://github.com/Azure/adx-documentation-pr) for more information.

---
_This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments._
Loading

0 comments on commit 48cbe58

Please sign in to comment.