Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run when in build dir #957

Merged
merged 4 commits into from
Jan 18, 2020
Merged

Fix run when in build dir #957

merged 4 commits into from
Jan 18, 2020

Conversation

jkoan
Copy link
Member

@jkoan jkoan commented Jan 15, 2020

As a follow up for #803 now hers a working fix which will work with all build systems supported by cmake.
If creates a new file which which navit is searching for. If Navit finds this it will run in build dir mode.
The file itself will not be included into binary distributions as desired.

@jkoan jkoan requested review from aerostitch and hoehnp January 15, 2020 21:59
@jkoan jkoan force-pushed the fix_run_in_build_dir branch from a75e7be to 643b6cc Compare January 16, 2020 07:40
Copy link
Contributor

@aerostitch aerostitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane.

@aerostitch aerostitch mentioned this pull request Jan 18, 2020
@pgrandin pgrandin merged commit 37715fe into trunk Jan 18, 2020
@pgrandin pgrandin deleted the fix_run_in_build_dir branch January 18, 2020 23:07
viktorgino pushed a commit that referenced this pull request Sep 22, 2020
* add:build:core:Add file which is only visible to devs to detect when navit is running in build dir
jkoan added a commit to jkoan/navit that referenced this pull request Jun 30, 2021
* add:build:core:Add file which is only visible to devs to detect when navit is running in build dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants