fix:maptool:create valid zip64 central directory #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the zip64 central directory created by the maptool. While the broken one works on navit itselve, it failed to extract with usual zip tools due to parts of the zip64 end of directory part not being filled correctly with values.
jkoan
approved these changes
Oct 18, 2019
|
As far as i rememper from reading the zip spec some time ago this is correct :D |
|
Merging this. Hope it doesn't have any negative effect on the planet extractor. |
jkoan
pushed a commit
to jkoan/navit
that referenced
this pull request
Oct 24, 2019
This fixes the zip64 central directory created by the maptool. While the broken one works on navit itselve, it failed to extract with usual zip tools due to parts of the zip64 end of directory part not being filled correctly with values.
hoehnp
pushed a commit
that referenced
this pull request
Nov 4, 2019
This fixes the zip64 central directory created by the maptool. While the broken one works on navit itselve, it failed to extract with usual zip tools due to parts of the zip64 end of directory part not being filled correctly with values.
viktorgino
pushed a commit
that referenced
this pull request
Sep 22, 2020
This fixes the zip64 central directory created by the maptool. While the broken one works on navit itselve, it failed to extract with usual zip tools due to parts of the zip64 end of directory part not being filled correctly with values.
jkoan
pushed a commit
to jkoan/navit
that referenced
this pull request
Jun 30, 2021
This fixes the zip64 central directory created by the maptool. While the broken one works on navit itselve, it failed to extract with usual zip tools due to parts of the zip64 end of directory part not being filled correctly with values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the zip64 central directory created by the maptool.
While the broken one works on navit, it failed to extract with usual zip
tools due to parts of the zip64 end of directory part not being filled
correctly with values.
This happens on all 64 bit zip files generated by maptool including the sample map since the multipolygon patches.
Files downloaded from planet extractor are and always have been corrupt as well. Without the source of the planet extractor, I don't know if this actually fixes the files shared by planet extractor as well.