fix:core:add clipping to polygons with holes #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extracts the polygon clipping into its own function to be re used for polygon with holes clipping.
While this helps drawing for limited graphics like SDL or WindowsCE, it will slightly slow down on graphics that do clipping themselves like qt5. As this is done for polygons already, we do this for polygons with holes as well.
2f0ceea to
e9911d4
Compare
|
I will ignore CodeFactor once more, as it is totally stupid to implement, and test code, and then on creating the pull request being told by CodeFactor it was too complex. I will not rewrite tested code because of this. It's hard to guess the metric of CodeFactor applies. |
|
Merging this as confirmed to be fine in #869 |
viktorgino
pushed a commit
that referenced
this pull request
Sep 22, 2020
* fix:core:refactor polygon clipping This commit extracts the polygon clipping into its own function to be re used for polygon with holes clipping. * fix:core:Clip polygons with holes prior drawing. While this helps drawing for limited graphics like SDL or WindowsCE, it will slightly slow down on graphics that do clipping themselves like qt5. As this is done for polygons already, we do this for polygons with holes as well.
jkoan
pushed a commit
to jkoan/navit
that referenced
this pull request
Jun 30, 2021
…avit-gps#869) * fix:core:refactor polygon clipping This commit extracts the polygon clipping into its own function to be re used for polygon with holes clipping. * fix:core:Clip polygons with holes prior drawing. While this helps drawing for limited graphics like SDL or WindowsCE, it will slightly slow down on graphics that do clipping themselves like qt5. As this is done for polygons already, we do this for polygons with holes as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As some simple graphics like SDL or windows CE do not clip on drawing, the rendering performance of huge (not necessary in node count but on screen) polygons with holes cause poor drawing performance even if only small portions of those polygons are on screen.
To fix this we clip polygons with holes before calling back end to draw like done with traditional polygons as well.