Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no redraw of map when stopping drag over osd_speed_warner, osd_stopwatch and osd_odometer #814

Merged
merged 3 commits into from
Jul 25, 2019

Conversation

hoehnp
Copy link
Contributor

@hoehnp hoehnp commented Jul 22, 2019

PR on behalf on @gefin

hoehnp added 2 commits July 8, 2019 21:47
	ändrad:        navit/binding/dbus/binding_dbus.c
…topwatch and osd_odometer

	ändrad:        navit/osd/core/osd_core.c
@hoehnp hoehnp requested review from pgrandin, jkoan and gefin July 22, 2019 19:52
@gefin
Copy link
Contributor

gefin commented Jul 23, 2019

looks like the cleanup in binding_dbus.c make a "sequence" problem:

In file included from /root/project/navit/binding/dbus/binding_dbus.c:44:0:
/root/project/navit/osd.h:48:15: error: field 'color_bg' has incomplete type
struct color color_bg, color_fg, text_color;

aproved osd_core

Copy link
Contributor

@gefin gefin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the second use of layout.h should be removed. not the first.
looks like osd.h need it.

@metalstrolch
Copy link
Contributor

Fixed the includes. Don't know why CircleCI thinks it needs to merge to master. Maybe because its "trunk" on hoehnp/navit ...

@metalstrolch metalstrolch merged commit b6c0c86 into navit-gps:trunk Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants