qt5: Remove unnecessary moc includes. #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes moc file includes for some classes which do not define new qt classes. This caused a long standing warning which seems to be treated as error on some setups.
Here you got your bloody spaces. Uber picky, isn't it?
jkoan
approved these changes
Jun 18, 2019
|
@metalstrolch QAudio::InterruptedState was added in qt 5.10. |
Sailfish version of QT doesn't feature this yet.
|
No, unless Jolla decides to do, we cannot update QT |
jandegr
added a commit
to jandegr/navit
that referenced
this pull request
Jun 23, 2019
* Fix:core:Fix item_def.h when used whithout defined macros (like in IDE) * Adding comments and const * Change Variable to y because it holds the real string * Fix:core:Fix Warning in IDE for Items not found * Refactoring:cmake:simplify version management * Refactoring:cmake:from 2.6 to 3.2 * Fixed typos * Add:Gui/Internal: Adding missing escape modes and fixing generic html escape mode (navit-gps#785) * Adding missing escape modes and fixing generic html escape mode * Fixing comment * Lining-up style * Small typo fix * Readthedocs import (navit-gps#784) * First rftd.io import * Testing Markdown doc * Testing Markdown doc * Testing RST * Datetime is required * Testing RST * Adding a basic configuration page from the wiki * Testing RST * Testing syntax highlighting * Testing syntax highlighting * Testing syntax highlighting * Importing https://wiki.navit-project.org/index.php/Maps * Importing https://wiki.navit-project.org/index.php/Maps * Importing https://wiki.navit-project.org/index.php/Binfile * Importing https://wiki.navit-project.org/index.php/Binfile * Importing https://wiki.navit-project.org/index.php/Binfile * Importing https://wiki.navit-project.org/index.php/Binfile * Importing https://wiki.navit-project.org/index.php/Binfile * Importing https://wiki.navit-project.org/index.php/Binfile * Importing https://wiki.navit-project.org/index.php/Binfile * Importing https://wiki.navit-project.org/index.php/Binfile * Importing https://wiki.navit-project.org/index.php/Binfile * Importing https://wiki.navit-project.org/index.php/Binfile * Importing https://wiki.navit-project.org/index.php/Binfile * Importing https://wiki.navit-project.org/index.php/Binfile * Importing https://wiki.navit-project.org/index.php/OpenStreetMap * Importing https://wiki.navit-project.org/index.php/OpenStreetMap * Importing https://wiki.navit-project.org/index.php/OpenStreetMap * Importing https://wiki.navit-project.org/index.php/OpenStreetMap * Importing https://wiki.navit-project.org/index.php/OpenStreetMap * Importing https://wiki.navit-project.org/index.php/OpenStreetMap * Importing https://wiki.navit-project.org/index.php/OpenStreetMap * Importing https://wiki.navit-project.org/index.php/OpenStreetMap * Fixing links * Fixing links * Fixing links * Fixing links * Fixing links * Minor improvments * Minor improvments * Minor fixes * Importing detailed configuration * Improving the index page * Removing copyright, it makes CodeFactor unhappy * Added misspell checks * Fixed wrong copy pasta * Install curl, required to install misspell * Fixed some typos * Removed a bunch of trailing spaces * Removed a bunch of trailing spaces * Probably don't need "please" here. * Reworking content * Apply suggestions from code review Remove unneeded white spaces before colon * Apply suggestions from code review Setting song for software or file names like the other occurences * Update docs/binfile.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/advanced.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/advanced.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Removed wiki comment * Update docs/configuration/display.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/display.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/general.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/general.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/general.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/index.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/index.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/layout.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/vehicle.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/vehicle.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/vehicle.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/vehicle.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/index.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/index.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/index.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/index.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Update docs/configuration/display.rst Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * Apply suggestions from code review Co-Authored-By: Joseph Herlant <aerostitch@users.noreply.github.com> * update:doc: add the submit patches section from the old wiki close to the code * Fix typos * Fix:bookmarks:Ensure that bookmarks are synced to disk * fix:style:Fix tabs vs. spaces * update:doc: Update the contributing.md to add the contributing section of the Programming guidelines (navit-gps#793) * Disable maptool if protobuf-c not found * fix:graphics:qt5: Remove unnecessary moc includes. (navit-gps#798) * Remove unnecessary moc includes. This commit removes moc file includes for some classes which do not define new qt classes. This caused a long standing warning which seems to be treated as error on some setups. * Make (in)sanity check happy. Here you got your bloody spaces. Uber picky, isn't it? * Remove QAudio::interruptedState again Sailfish version of QT doesn't feature this yet. * Migrate the programming guidelines documentation to readthedocs (navit-gps#799)
jkoan
pushed a commit
to jkoan/navit
that referenced
this pull request
Jun 30, 2021
* Remove unnecessary moc includes. This commit removes moc file includes for some classes which do not define new qt classes. This caused a long standing warning which seems to be treated as error on some setups. * Make (in)sanity check happy. Here you got your bloody spaces. Uber picky, isn't it? * Remove QAudio::interruptedState again Sailfish version of QT doesn't feature this yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes moc file includes for some classes which do not
define new qt classes. This caused a long standing warning which seems
to be treated as error on some setups.
Additionally a small fix to make nit-picky gcc 8 happy.