Missing "polygon with holes" support for android #852
Comments
|
Added Windows support except CE to #824. |
|
Is there a way to add wince as well? i can do the test on wince |
|
Not on the fly and not for me. But as not being a Windows dev, and the documentation about WindowsCE (C language specially) is really limited I may be wrong, but it seems I'm done here. I don't have any Device to test either, and the development cycles with only CI as build environment is rather slow. Hopefully someone with Windows CE knowledge may help out here. Btw. I wonder that this old system is still in productive use. -> I added WindowsCE support after seeing how it can be done in SDL. |
|
Add SDL with #861 |
|
Add Windows CE with #862 |
|
Really nice work @metalstrolch We have an experimental openSTF farm available. This could allow you to test android related features. Would you be interested? |
|
Thanks for the offer @pgrandin, Last but not least it would require me to learn coding habits for Android, as #832 convinces me is something I better not make my fingers dirty. I don't like to be blamed for code I write for alien architectures barely knowing the system. I was still hoping somebody with Android knowledge could at least try to set up the new graphics function. The learning curve seems to be too ineffective for doing this on my own.
|
With the introduction of the multipolygon code we now have all the nice landuses in the map. However, in OSM there are some map features that are not mapped as multipolygon but just "above" the other landuses. Like poly_zoo, poly_theme_park or poly_airfield. Current configuration causes them to be hidden by the landuses, as these are drawn after the above mentioned. OSM's Mapnik style solves the problem by drawing those feature transparent above the landuses. This pull request does so for some map features as well causing the map to look way better. If transparent drawing is not supported by the platform, this causes the mentioned polys to be drawn above the landuses, showing them, eventually hiding some landuse details underneath. But this looks even better than before too. NOTE: Transparent drawing is known to work on: Qt5 (sailfish) and gtk. NOTE: Transparent drawing is known NOT to work on SDL Dont't know for all the others. Sombody might want to check Android? Remember #852 on comparing screenshots though. * Fix: layout_car: draw map features transparent on top Some map featuresa re usually not put into multipolygons, but simple tagged "on top" of the others. So It's quite common for example to tag "poly_airport" on top of the underlying other landuses inside the airport. Move (some) of those elements on top of the polygon draw stack and make them transparent. Looks way better on graphics that support transparency. Not much is lost on those that don't. * Fix: layout_car: differentiate meadow and farmland in color * enhancement:layout-car:Make poly_barracks and poly_university transparent
|
Hello @metalstrolch. I do have a build environment and several target machines for Android if testing is needed. |
|
@metalstrolch i understand your point about having to learn the java part. I'm in the same boat. I'll chime in #832 regarding CodeStyle but wanted to say this anyway : CodeStyle is a tool to help us improve our code. One way to do it is to fix old code style issues (there's sometimes really good fixes that can be uncovered) and another way is to prevent us from adding new issues. Everybody is contributing with the goal to make Navit better. It's OK if you want to focus on one topic or one architecture. It's also OK if you submit a not perfect pull request to address an issue you've uncovered. Hopefully someone who knows more about that area can help and improve it. Your contributions are welcome. |
|
Ok, let ranting aside and do something, just to start another ranting. |
With the introduction of the multipolygon code we now have all the nice landuses in the map. However, in OSM there are some map features that are not mapped as multipolygon but just "above" the other landuses. Like poly_zoo, poly_theme_park or poly_airfield. Current configuration causes them to be hidden by the landuses, as these are drawn after the above mentioned. OSM's Mapnik style solves the problem by drawing those feature transparent above the landuses. This pull request does so for some map features as well causing the map to look way better. If transparent drawing is not supported by the platform, this causes the mentioned polys to be drawn above the landuses, showing them, eventually hiding some landuse details underneath. But this looks even better than before too. NOTE: Transparent drawing is known to work on: Qt5 (sailfish) and gtk. NOTE: Transparent drawing is known NOT to work on SDL Dont't know for all the others. Sombody might want to check Android? Remember #852 on comparing screenshots though. * Fix: layout_car: draw map features transparent on top Some map featuresa re usually not put into multipolygons, but simple tagged "on top" of the others. So It's quite common for example to tag "poly_airport" on top of the underlying other landuses inside the airport. Move (some) of those elements on top of the polygon draw stack and make them transparent. Looks way better on graphics that support transparency. Not much is lost on those that don't. * Fix: layout_car: differentiate meadow and farmland in color * enhancement:layout-car:Make poly_barracks and poly_university transparent
…vit-gps#879) With the introduction of the multipolygon code we now have all the nice landuses in the map. However, in OSM there are some map features that are not mapped as multipolygon but just "above" the other landuses. Like poly_zoo, poly_theme_park or poly_airfield. Current configuration causes them to be hidden by the landuses, as these are drawn after the above mentioned. OSM's Mapnik style solves the problem by drawing those feature transparent above the landuses. This pull request does so for some map features as well causing the map to look way better. If transparent drawing is not supported by the platform, this causes the mentioned polys to be drawn above the landuses, showing them, eventually hiding some landuse details underneath. But this looks even better than before too. NOTE: Transparent drawing is known to work on: Qt5 (sailfish) and gtk. NOTE: Transparent drawing is known NOT to work on SDL Dont't know for all the others. Sombody might want to check Android? Remember navit-gps#852 on comparing screenshots though. * Fix: layout_car: draw map features transparent on top Some map featuresa re usually not put into multipolygons, but simple tagged "on top" of the others. So It's quite common for example to tag "poly_airport" on top of the underlying other landuses inside the airport. Move (some) of those elements on top of the polygon draw stack and make them transparent. Looks way better on graphics that support transparency. Not much is lost on those that don't. * Fix: layout_car: differentiate meadow and farmland in color * enhancement:layout-car:Make poly_barracks and poly_university transparent
It is planned to include multipolygon support #824 into navit before 0.5.4 release, which is a good thing indeed.
However for full experience of the then enhanced maps, it would be good to add graphics support for drawing polygons with holes on Android, SDL and Windows CE targets as well.
I added Windows support (except CE) to #824 as it was no big issue to do even with only CI as build environment.
I added Windows CE support in #862
I added SDL support in #861
Despite willing to do so I cannot help much for android, as I don't have access to any Android device to test the result. But I am willing to help pointing out what needs to be done.
The text was updated successfully, but these errors were encountered: